Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

[Documentation] Can not initialize the QueueMessagingTemplate #537

Closed
luramarchanjo opened this issue Apr 1, 2020 · 5 comments
Closed
Labels
component: sqs SQS integration related issue type: documentation A documentation update
Milestone

Comments

@luramarchanjo
Copy link
Contributor

luramarchanjo commented Apr 1, 2020

There is wrong documentation about Amazon Simple Queue Service (AWS SQS) related to QueueMessagingTemplate

import com.amazonaws.services.sqs.AmazonSQS;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.cloud.aws.messaging.core.QueueMessagingTemplate;
import org.springframework.messaging.support.MessageBuilder;

public class SqsQueueSender {

    private final QueueMessagingTemplate queueMessagingTemplate;

    @Autowired
    public SqsQueueSender(AmazonSQS amazonSqs) {
        this.queueMessagingTemplate = new QueueMessagingTemplate(amazonSqs);
    }

    public void send(String message) {
        this.queueMessagingTemplate.send("physicalQueueName", MessageBuilder.withPayload(message).build());
    }
}

Is not possible to initialize QueueMessagingTemplate using the AmazonSQS

It is only possible, using the AmazonSQSAsync

import com.amazonaws.services.sqs.AmazonSQSAsync;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.cloud.aws.messaging.core.QueueMessagingTemplate;
import org.springframework.messaging.support.MessageBuilder;

public class SqsQueueSender {

    private final QueueMessagingTemplate queueMessagingTemplate;

    @Autowired
    public SqsQueueSender(AmazonSQSAsync amazonSQSAsync) {
        this.queueMessagingTemplate = new QueueMessagingTemplate(amazonSQSAsync);
    }

    public void send(String message) {
        this.queueMessagingTemplate.send("physicalQueueName", MessageBuilder.withPayload(message).build());
    }
}
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 1, 2020
@maciejwalkowiak maciejwalkowiak added component: sqs SQS integration related issue type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels May 29, 2020
@maciejwalkowiak maciejwalkowiak added this to the 2.2.3 milestone May 29, 2020
@maciejwalkowiak
Copy link
Contributor

Thanks @larchanjo for reporting. Would you like to contribute a fix to documentation?

@luramarchanjo
Copy link
Contributor Author

Hi, @maciejwalkowiak I would like, but I don't know where is the documentation repo, can you help me?

@maciejwalkowiak
Copy link
Contributor

Sure! It's in this very github repository: https://github.com/spring-cloud/spring-cloud-aws/blob/master/docs/src/main/asciidoc/spring-cloud-aws.adoc

@luramarchanjo
Copy link
Contributor Author

@maciejwalkowiak Thank you soo much, the PR is #558

@maciejwalkowiak
Copy link
Contributor

Thanks @larchanjo. Merged in #558 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: sqs SQS integration related issue type: documentation A documentation update
Development

No branches or pull requests

3 participants