Skip to content

[Security Suggestion] Increase PBKDF2-HMAC Iterations for Stronger Key Derivation #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
choseogyeong opened this issue Apr 16, 2025 · 0 comments
Open

[Security Suggestion] Increase PBKDF2-HMAC Iterations for Stronger Key Derivation #9742

choseogyeong opened this issue Apr 16, 2025 · 0 comments

Comments

@choseogyeong
Copy link

Description

Hi, while reviewing the code I noticed that the PBKDF2-HMAC implementation currently uses:

return to_hexstr(hashlib.pbkdf2_hmac('sha512', key, b'Digital Bitbox', iterations = 20480))

According to OWASP 2023 recommendations, the recommended minimum for PBKDF2-HMAC-SHA512 is 210,000 iterations.

This should significantly improve security and protect against brute-force attacks.
Would it be possible to update this in future releases?

Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@choseogyeong