Added LoRa Thing Plus, removed other accidental changes #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes are looking pretty good. I should be getting a board in my hands today or monday to do some testing and ill let you know if I have any feedback then. |
Wenn0101
approved these changes
Jan 7, 2021
| //***************************************************************************** | ||
| const am_hal_gpio_pincfg_t g_AM_BSP_GPIO_BUTTON0 = | ||
| { | ||
| .uFuncSel = AM_HAL_PIN_48_GPIO, |
There was a problem hiding this comment.
This button moved on the hardware rev made by @lewispg228 . Leaving this comment here to remember to change this before completing the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added target for LoRa thing plus in mbed to support Arduino core.
Removed changes which were likely due to not updating fork prior to PR.
Submitting along with PR sparkfun/Arduino_Apollo3#305, adding the LoRa thing plus variant to Arduino core