Merge pull request #1 from tadas-s/master

andreadevo · web-flow · commit 02ab70fc2db2 · 2019-03-04T10:51:41.000-07:00
Fix couple miscallenous issues: unused variables + default argument in implementation
diff --git a/src/SparkFun_PCA9536_Arduino_Library.cpp b/src/SparkFun_PCA9536_Arduino_Library.cpp
@@ -51,9 +51,6 @@ boolean PCA9536::begin(void)
 
 PCA9536_error_t PCA9536::begin(TwoWire &wirePort) 
 {
-    uint8_t systemControl = 0;
-    PCA9536_error_t retVal;
-
     _deviceAddress = PCA9536_ADDRESS;
     _i2cPort = &wirePort;
 
@@ -133,7 +130,7 @@ uint8_t PCA9536::digitalRead(uint8_t pin)
     return read(pin);
 }
 
-PCA9536_error_t PCA9536::invert(uint8_t pin, PCA9536_invert_t inversion = PCA9536_INVERT)
+PCA9536_error_t PCA9536::invert(uint8_t pin, PCA9536_invert_t inversion)
 {
     PCA9536_error_t err;
     uint8_t invertRegister = 0;
@@ -214,4 +211,4 @@ PCA9536_error_t PCA9536::readI2CRegister(uint8_t * dest, PCA9536_REGISTER_t regi
 PCA9536_error_t PCA9536::writeI2CRegister(uint8_t data, PCA9536_REGISTER_t registerAddress)
 {
     return writeI2CBuffer(&data, registerAddress, 1);
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,6 @@ boolean PCA9536::begin(void)`
`51`	`51`
`52`	`52`	`PCA9536_error_t PCA9536::begin(TwoWire &wirePort)`
`53`	`53`	`{`
`54`		`- uint8_t systemControl = 0;`
`55`		`- PCA9536_error_t retVal;`
`56`		`-`
`57`	`54`	`_deviceAddress = PCA9536_ADDRESS;`
`58`	`55`	`_i2cPort = &wirePort;`
`59`	`56`
`@@ -133,7 +130,7 @@ uint8_t PCA9536::digitalRead(uint8_t pin)`
`133`	`130`	`return read(pin);`
`134`	`131`	`}`
`135`	`132`
`136`		`-PCA9536_error_t PCA9536::invert(uint8_t pin, PCA9536_invert_t inversion = PCA9536_INVERT)`
	`133`	`+PCA9536_error_t PCA9536::invert(uint8_t pin, PCA9536_invert_t inversion)`
`137`	`134`	`{`
`138`	`135`	`PCA9536_error_t err;`
`139`	`136`	`uint8_t invertRegister = 0;`
`@@ -214,4 +211,4 @@ PCA9536_error_t PCA9536::readI2CRegister(uint8_t * dest, PCA9536_REGISTER_t regi`
`214`	`211`	`PCA9536_error_t PCA9536::writeI2CRegister(uint8_t data, PCA9536_REGISTER_t registerAddress)`
`215`	`212`	`{`
`216`	`213`	`return writeI2CBuffer(&data, registerAddress, 1);`
`217`		`-}`
	`214`	`+}`