feat: Function to adjust SBD Session Timeout

[ndoo]

Independent of existing code, but open to suggestions/feedback.

[ndoo]

Rebased on main HEAD

[ndoo]

Converting to draft, it only works if called after begin(), so I think this has to be tracked as a variable...

[ndoo]

Ready for review, tried to reduce the impact as much as possible.

[PaulZC]

This is looking good Andrew (@ndoo ),

Please have a think about adding the changes suggested below.

I can't see any potential problems. And it maintains backwards compatibility. Thanks!

I don't know what would happen if the user called this while a SBDIX was already in progress? But that's a very fringe case...

[ndoo]

Force pushed with requested changes + minor code style change for the if statement (curly brace on new line)

[ndoo]

I think this is not possible to call during SBDIX with the current library as AFAICT there is no async functionality, so SBDIX is blocking.

[PaulZC]

Thank you for the updates Andrew (@ndoo ),

I will let this sit for a few days, just in case you want to add or change anything. Please give me a nudge if I have not merged it by this time next week.

Best wishes,
Paul

[ndoo]

Thank you for the updates Andrew (@ndoo ),

I will let this sit for a few days, just in case you want to add or change anything. Please give me a nudge if I have not merged it by this time next week.

Sounds good to me. It'll give us some time to let our code cycle through a bunch of Tx cycles too. If I notice any regressions or ill effects I'll likewise communicate here.

Cheers.