Skip to content

Feature request: ISO 8601 time format #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamgarbo opened this issue Mar 27, 2022 · 2 comments · Fixed by #119
Closed

Feature request: ISO 8601 time format #118

adamgarbo opened this issue Mar 27, 2022 · 2 comments · Fixed by #119
Labels

Comments

@adamgarbo
Copy link
Contributor

Hi @PaulZC,

What are your thoughts on enabling the OLA to log its date and time as a single ISO 8601 string? I know the Americans are fond of their mm/dd/yyyy format, but I think the adoption of an internationally recognized standard could make sense. For those of us who are ingesting the raw data into Python, it'll also help to save some time not having to manually parse the dates and times.

Relevant xkcd:
https://xkcd.com/1179/

Cheers,
Adam

@PaulZC
Copy link
Collaborator

PaulZC commented Mar 28, 2022

Hi @adamgarbo ,

I need to revisit the OLA firmware - today as it happens. I'll take a look at this. We'll need to maintain backward-compatibility, but maybe I can add in an extra option for ISO time.

Cheers,
Paul

@PaulZC PaulZC added enhancement New feature or request under consideration labels Mar 28, 2022
@PaulZC
Copy link
Collaborator

PaulZC commented Apr 8, 2022

Added in v2.2. The firmware now supports both yyyy/mm/dd and ISO 8601 formatting. Use menu 2) "Configure Time Stamp" option 5) "Toggle date style" to change the format. The date format will cycle between mm/dd/yyyy, dd/mm/yyyy, yyyy/mm/dd and yyyy-mm-ddThh:mm:ss+hh:mm . With ISO 8601 selected, you can still log the time too - which is useful if you need 0.01s time resolution. The ISO 8601 time zone is taken from option 9) "Local offset from UTC".

@PaulZC PaulZC linked a pull request Apr 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants