Skip to content

Revert changes that make parameters local #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Revert changes that make parameters local #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ScipDotnet/ScipDocumentIndexer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ private static bool IsLocalSymbol(ISymbol sym)
{
return sym.Kind == SymbolKind.Local ||
sym.Kind == SymbolKind.RangeVariable ||
sym.Kind == SymbolKind.Parameter ||
sym.Kind == SymbolKind.TypeParameter ||
sym is IMethodSymbol { MethodKind: MethodKind.LocalFunction } ||
// Anonymous classes/methods have empty names and can not be accessed outside their file.
Expand Down
62 changes: 31 additions & 31 deletions snapshots/output-net6.0/syntax/Main/Classes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class Classes
public Classes(int name)
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#`.ctor`().
// documentation ```cs\npublic Classes.Classes(int name)\n```
// ^^^^ definition local 0
// ^^^^ definition scip-dotnet nuget . . Main/Classes#`.ctor`().(name)
// documentation ```cs\nint name\n```
{
Name = "name";
Expand All @@ -31,10 +31,10 @@ public Classes(int name)
public Classes(string name) => Name = name;
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#`.ctor`(+1).
// documentation ```cs\npublic Classes.Classes(string name)\n```
// ^^^^ definition local 1
// ^^^^ definition scip-dotnet nuget . . Main/Classes#`.ctor`(+1).(name)
// documentation ```cs\nstring name\n```
// ^^^^ reference scip-dotnet nuget . . Main/Classes#Name.
// ^^^^ reference local 1
// ^^^^ reference scip-dotnet nuget . . Main/Classes#`.ctor`(+1).(name)

~Classes()
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#Finalize().
Expand All @@ -60,117 +60,117 @@ public partial class PartialClass
class TypeParameterClass<T>
// ^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#TypeParameterClass#
// documentation ```cs\nclass TypeParameterClass<T>\n```
// ^ definition local 2
// ^ definition local 0
// documentation ```cs\nT\n```
{
}

internal class InternalMultipleTypeParametersClass<T1, T2>
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#InternalMultipleTypeParametersClass#
// documentation ```cs\nclass InternalMultipleTypeParametersClass<T1, T2>\n```
// ^^ definition local 3
// ^^ definition local 1
// documentation ```cs\nT1\n```
// ^^ definition local 4
// ^^ definition local 2
// documentation ```cs\nT2\n```
{
}

interface ICovariantContravariant<in T1, out T2>
// ^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#ICovariantContravariant#
// documentation ```cs\ninterface ICovariantContravariant<in T1, out T2>\n```
// ^^ definition local 5
// ^^ definition local 3
// documentation ```cs\nin T1\n```
// ^^ definition local 6
// ^^ definition local 4
// documentation ```cs\nout T2\n```
{
public void Method1(T1 t1)
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#ICovariantContravariant#Method1().
// documentation ```cs\nvoid ICovariantContravariant<in T1, out T2>.Method1(T1 t1)\n```
// ^^ reference local 5
// ^^ definition local 7
// ^^ reference local 3
// ^^ definition scip-dotnet nuget . . Main/Classes#ICovariantContravariant#Method1().(t1)
// documentation ```cs\nT1 t1\n```
{
Console.WriteLine(t1);
// ^^ reference local 7
// ^^ reference scip-dotnet nuget . . Main/Classes#ICovariantContravariant#Method1().(t1)
}

public T2? Method2()
// ^^ reference local 6
// ^^ reference local 4
// ^^^^^^^ definition scip-dotnet nuget . . Main/Classes#ICovariantContravariant#Method2().
// documentation ```cs\nT2? ICovariantContravariant<in T1, out T2>.Method2()\n```
{
return default(T2);
// ^^ reference local 6
// ^^ reference local 4
}
}

public class StructConstraintClass<T> where T : struct
// ^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#StructConstraintClass#
// documentation ```cs\nclass StructConstraintClass<T> where T : struct\n```
// ^ definition local 8
// ^ definition local 5
// documentation ```cs\nT\n```
// ^ reference local 8
// ^ reference local 5
{
}

public class UnmanagedConstraintClass<T> where T : unmanaged
// ^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#UnmanagedConstraintClass#
// documentation ```cs\nclass UnmanagedConstraintClass<T> where T : unmanaged\n```
// ^ definition local 9
// ^ definition local 6
// documentation ```cs\nT\n```
// ^ reference local 9
// ^ reference local 6
{
}

public class ClassConstraintClass<T> where T : class
// ^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#ClassConstraintClass#
// documentation ```cs\nclass ClassConstraintClass<T> where T : class\n```
// ^ definition local 10
// ^ definition local 7
// documentation ```cs\nT\n```
// ^ reference local 10
// ^ reference local 7
{
}

public class NonNullableConstraintClass<T> where T : notnull
// ^^^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#NonNullableConstraintClass#
// documentation ```cs\nclass NonNullableConstraintClass<T> where T : notnull\n```
// ^ definition local 11
// ^ definition local 8
// documentation ```cs\nT\n```
// ^ reference local 11
// ^ reference local 8
{
}

public class NewConstraintClass<T> where T : new()
// ^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#NewConstraintClass#
// documentation ```cs\nclass NewConstraintClass<T> where T : new()\n```
// ^ definition local 12
// ^ definition local 9
// documentation ```cs\nT\n```
// ^ reference local 12
// ^ reference local 9
{
}

public class TypeParameterConstraintClass<T> where T : SomeInterface
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#TypeParameterConstraintClass#
// documentation ```cs\nclass TypeParameterConstraintClass<T> where T : SomeInterface\n```
// ^ definition local 13
// ^ definition local 10
// documentation ```cs\nT\n```
// ^ reference local 13
// ^ reference local 10
// ^^^^^^^^^^^^^ reference scip-dotnet nuget . . Main/SomeInterface#
{
}

private class MultipleTypeParameterConstraintsClass<T1, T2> where T1 : SomeInterface, SomeInterface2, new()
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition scip-dotnet nuget . . Main/Classes#MultipleTypeParameterConstraintsClass#
// documentation ```cs\nclass MultipleTypeParameterConstraintsClass<T1, T2> where T1 : SomeInterface, SomeInterface2, new() where T2 : SomeInterface2\n```
// ^^ definition local 14
// ^^ definition local 11
// documentation ```cs\nT1\n```
// ^^ definition local 15
// ^^ definition local 12
// documentation ```cs\nT2\n```
// ^^ reference local 14
// ^^ reference local 11
// ^^^^^^^^^^^^^ reference scip-dotnet nuget . . Main/SomeInterface#
// ^^^^^^^^^^^^^^ reference scip-dotnet nuget . . Main/SomeInterface2#
where T2 : SomeInterface2
// ^^ reference local 15
// ^^ reference local 12
// ^^^^^^^^^^^^^^ reference scip-dotnet nuget . . Main/SomeInterface2#
{
}
Expand All @@ -184,14 +184,14 @@ class IndexClass
// documentation ```cs\nprivate bool IndexClass.a\n```

public bool this[int index]
// ^^^^^ definition local 16
// ^^^^^ definition scip-dotnet nuget . . Main/Classes#IndexClass#`this[]`.(index)
// documentation ```cs\nint index\n```
{
get { return a; }
// ^ reference scip-dotnet nuget . . Main/Classes#IndexClass#a.
set { a = value; }
// ^ reference scip-dotnet nuget . . Main/Classes#IndexClass#a.
// ^^^^^ reference local 17
// ^^^^^ reference scip-dotnet nuget . . Main/Classes#IndexClass#set_Item().(value)
}
}

Expand Down
Loading