Skip to content

Add Chapter 3 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ning-y merged 4 commits into from
Aug 1, 2018
Merged

Add Chapter 3 #22

ning-y merged 4 commits into from
Aug 1, 2018

Conversation

@remo5000
Copy link
Contributor

@remo5000 remo5000 commented Aug 1, 2018

Features

  • Move some list mutability functions
  • Enable new syntax

Testing

  • Copy the dist folder to the frontend repo node_modules/js-slang folder, overwriting the other content
  • Add an option for Chapter 3 in the frontend

@remo5000 remo5000 requested a review from ning-y August 1, 2018 04:22
@coveralls
Copy link

coveralls commented Aug 1, 2018

Pull Request Test Coverage Report for Build 20

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 48.221%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/createContext.ts 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/createContext.ts 1 82.14%
Totals Coverage Status
Change from base Build 18: 0.2%
Covered Lines: 614
Relevant Lines: 1167
💛 - Coveralls

@ning-y ning-y merged commit 88e20e3 into master Aug 1, 2018
@ning-y ning-y deleted the chapter-three branch August 1, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ning-y ning-y ning-y approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remo5000 @coveralls @ning-y