Create hasTokenCounter attribute to assessment_config (#1062)

* Create new attribute to assessment_config

* fix bug which cause tokenCounter to default false

* Fix format

* Modify controller tests

---------

Co-authored-by: DesSnowy <[email protected]>
Co-authored-by: Richard Dominick <[email protected]>
Co-authored-by: sayomaki <[email protected]>

Author: 4 people

lib/cadet/courses/assessment_config.ex

@@ -12,7 +12,8 @@ defmodule Cadet.Courses.AssessmentConfig do
     field(:type, :string)
     field(:show_grading_summary, :boolean, default: true)
     field(:is_manually_graded, :boolean, default: true)
-    # used by fronend to determine display styles
+    field(:has_token_counter, :boolean, default: false)
+    # used by frontend to determine display styles
     field(:early_submission_xp, :integer, default: 0)
     field(:hours_before_early_xp_decay, :integer, default: 0)
 
@@ -23,7 +24,7 @@ defmodule Cadet.Courses.AssessmentConfig do
 
   @required_fields ~w(course_id)a
   @optional_fields ~w(order type early_submission_xp
-    hours_before_early_xp_decay show_grading_summary is_manually_graded)a
+    hours_before_early_xp_decay show_grading_summary is_manually_graded has_token_counter)a
 
   def changeset(assessment_config, params) do
     assessment_config

lib/cadet_web/admin_views/admin_courses_view.ex

@@ -12,6 +12,7 @@ defmodule CadetWeb.AdminCoursesView do
       displayInDashboard: :show_grading_summary,
       isManuallyGraded: :is_manually_graded,
       earlySubmissionXp: :early_submission_xp,
+      hasTokenCounter: :has_token_counter,
       hoursBeforeEarlyXpDecay: :hours_before_early_xp_decay
     })
   end

lib/cadet_web/views/user_view.ex

@@ -125,6 +125,7 @@ defmodule CadetWeb.UserView do
             type: :type,
             displayInDashboard: :show_grading_summary,
             isManuallyGraded: :is_manually_graded,
+            hasTokenCounter: :has_token_counter,
             earlySubmissionXp: :early_submission_xp,
             hoursBeforeEarlyXpDecay: :hours_before_early_xp_decay
           })

priv/repo/migrations/20240206045330_add_has_token_counter_toggle_to_assessment_config.exs

@@ -0,0 +1,15 @@
+defmodule Cadet.Repo.Migrations.AddHasTokenCounterToggleToAssessmentConfig do
+  use Ecto.Migration
+
+  def up do
+    alter table(:assessment_configs) do
+      add(:has_token_counter, :boolean, null: false, default: false)
+    end
+  end
+
+  def down do
+    alter table(:assessment_configs) do
+      remove(:has_token_counter)
+    end
+  end
+end

test/cadet_web/admin_controllers/admin_courses_controller_test.exs

@@ -157,7 +157,8 @@ defmodule CadetWeb.AdminCoursesControllerTest do
           is_manually_graded: false,
           order: 2,
           type: "Mission2",
-          course: course
+          course: course,
+          has_token_counter: true
         })
 
       resp =
@@ -172,23 +173,26 @@ defmodule CadetWeb.AdminCoursesControllerTest do
           "displayInDashboard" => true,
           "isManuallyGraded" => true,
           "type" => "Mission1",
-          "assessmentConfigId" => config1.id
+          "assessmentConfigId" => config1.id,
+          "hasTokenCounter" => false
         },
         %{
           "earlySubmissionXp" => 200,
           "hoursBeforeEarlyXpDecay" => 48,
           "displayInDashboard" => false,
           "isManuallyGraded" => false,
           "type" => "Mission2",
-          "assessmentConfigId" => config2.id
+          "assessmentConfigId" => config2.id,
+          "hasTokenCounter" => true
         },
         %{
           "earlySubmissionXp" => 200,
           "hoursBeforeEarlyXpDecay" => 48,
           "displayInDashboard" => true,
           "isManuallyGraded" => true,
           "type" => "Mission3",
-          "assessmentConfigId" => config3.id
+          "assessmentConfigId" => config3.id,
+          "hasTokenCounter" => false
         }
       ]
 

test/cadet_web/controllers/user_controller_test.exs

@@ -122,23 +122,26 @@ defmodule CadetWeb.UserControllerTest do
             "isManuallyGraded" => true,
             "assessmentConfigId" => config1.id,
             "earlySubmissionXp" => 200,
-            "hoursBeforeEarlyXpDecay" => 48
+            "hoursBeforeEarlyXpDecay" => 48,
+            "hasTokenCounter" => false
           },
           %{
             "type" => "test type 2",
             "displayInDashboard" => true,
             "isManuallyGraded" => true,
             "assessmentConfigId" => config2.id,
             "earlySubmissionXp" => 200,
-            "hoursBeforeEarlyXpDecay" => 48
+            "hoursBeforeEarlyXpDecay" => 48,
+            "hasTokenCounter" => false
           },
           %{
             "type" => "test type 3",
             "displayInDashboard" => true,
             "isManuallyGraded" => true,
             "assessmentConfigId" => config3.id,
             "earlySubmissionXp" => 200,
-            "hoursBeforeEarlyXpDecay" => 48
+            "hoursBeforeEarlyXpDecay" => 48,
+            "hasTokenCounter" => false
           }
         ]
       }