Skip to content

Commit 72654d3

Browse files
committed
Comment out calls to httptest.Server.Close() to work around
golang/go#12262 . See kubernetes#19254 for more details. This change should be reverted when we upgrade to Go 1.6.
1 parent 2f23ba6 commit 72654d3

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

plugin/pkg/auth/authenticator/token/oidc/oidc_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,8 @@ func TestOIDCDiscoveryNoKeyEndpoint(t *testing.T) {
218218
t.Fatalf("Cannot load cert/key pair: %v", err)
219219
}
220220
srv.StartTLS()
221-
defer srv.Close()
221+
// TODO: Uncomment when fix #19254
222+
// defer srv.Close()
222223

223224
op.pcfg = oidc.ProviderConfig{
224225
Issuer: srv.URL,
@@ -274,7 +275,8 @@ func TestOIDCDiscoverySecureConnection(t *testing.T) {
274275
t.Fatalf("Cannot load cert/key pair: %v", err)
275276
}
276277
tlsSrv.StartTLS()
277-
defer tlsSrv.Close()
278+
// TODO: Uncomment when fix #19254
279+
// defer tlsSrv.Close()
278280

279281
op.pcfg = oidc.ProviderConfig{
280282
Issuer: tlsSrv.URL,
@@ -309,7 +311,8 @@ func TestOIDCAuthentication(t *testing.T) {
309311
t.Fatalf("Cannot load cert/key pair: %v", err)
310312
}
311313
srv.StartTLS()
312-
defer srv.Close()
314+
// TODO: Uncomment when fix #19254
315+
// defer srv.Close()
313316

314317
op.pcfg = oidc.ProviderConfig{
315318
Issuer: srv.URL,

0 commit comments

Comments
 (0)