From f2f95e074eb81c1edb56c56a33014e360c524ca8 Mon Sep 17 00:00:00 2001 From: alex Date: Wed, 7 Aug 2024 18:33:02 +0900 Subject: [PATCH] fix: track socket before run middlewares --- packages/socket.io/lib/namespace.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/socket.io/lib/namespace.ts b/packages/socket.io/lib/namespace.ts index 8e0d2d89e9..bedf075b19 100644 --- a/packages/socket.io/lib/namespace.ts +++ b/packages/socket.io/lib/namespace.ts @@ -322,6 +322,9 @@ export class Namespace< debug("adding socket to nsp %s", this.name); const socket = await this._createSocket(client, auth); + // track socket + this.sockets.set(socket.id, socket); + if ( // @ts-ignore this.server.opts.connectionStateRecovery?.skipMiddlewares && @@ -389,9 +392,6 @@ export class Namespace< socket: Socket ) => void ) { - // track socket - this.sockets.set(socket.id, socket); - // it's paramount that the internal `onconnect` logic // fires before user-set events to prevent state order // violations (such as a disconnection before the connection