Rename needed_methods to callable_methods

Author: Owen Jones

src/java_bytecode/ci_lazy_methods.cpp

@@ -113,9 +113,9 @@ bool ci_lazy_methodst::operator()(
   std::set<irep_idt> instantiated_classes;
 
   {
-    std::vector<irep_idt> initial_needed_methods;
+    std::vector<irep_idt> initial_callable_methods;
     ci_lazy_methods_neededt initial_lazy_methods(
-      initial_needed_methods,
+      initial_callable_methods,
       instantiated_classes,
       symbol_table);
     initialize_instantiated_classes(
@@ -124,8 +124,8 @@ bool ci_lazy_methodst::operator()(
       initial_lazy_methods);
     method_worklist2.insert(
       method_worklist2.end(),
-      initial_needed_methods.begin(),
-      initial_needed_methods.end());
+      initial_callable_methods.begin(),
+      initial_callable_methods.end());
   }
 
   std::set<irep_idt> methods_already_populated;

src/java_bytecode/ci_lazy_methods_needed.cpp

@@ -20,7 +20,7 @@ Author: Chris Smowton, [email protected]
 void ci_lazy_methods_neededt::add_needed_method(
   const irep_idt &method_symbol_name)
 {
-  needed_methods.push_back(method_symbol_name);
+  callable_methods.push_back(method_symbol_name);
 }
 
 /// Notes class `class_symbol_name` will be instantiated, or a static field

src/java_bytecode/ci_lazy_methods_needed.h

@@ -20,10 +20,10 @@ class ci_lazy_methods_neededt
 {
 public:
   ci_lazy_methods_neededt(
-    std::vector<irep_idt> &_needed_methods,
+    std::vector<irep_idt> &_callable_methods,
     std::set<irep_idt> &_instantiated_classes,
     symbol_tablet &_symbol_table):
-  needed_methods(_needed_methods),
+  callable_methods(_callable_methods),
   instantiated_classes(_instantiated_classes),
   symbol_table(_symbol_table)
   {}
@@ -33,12 +33,12 @@ class ci_lazy_methods_neededt
   bool add_needed_class(const irep_idt &);
 
 private:
-  // needed_methods is a vector because it's used as a work-list
+  // callable_methods is a vector because it's used as a work-list
   // which is periodically cleared. It can't be relied upon to
   // contain all methods that have previously been elaborated.
   // It should be changed to a set if we develop the need to use
   // it that way.
-  std::vector<irep_idt> &needed_methods;
+  std::vector<irep_idt> &callable_methods;
   // instantiated_classes on the other hand is a true set of every class
   // found so far, so we can use a membership test to avoid
   // repeatedly exploring a class hierarchy.