From ba2921f876fd36f02b3026aeac718c019c0f6dee Mon Sep 17 00:00:00 2001 From: yuji-hatakeyama Date: Fri, 21 Feb 2025 19:32:58 +0900 Subject: [PATCH 1/3] fix(node-http-handler): fix constructor socketAcquisitionWarningTimeout does not work --- .changeset/popular-dolls-allow.md | 5 +++++ packages/node-http-handler/src/node-http-handler.ts | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .changeset/popular-dolls-allow.md diff --git a/.changeset/popular-dolls-allow.md b/.changeset/popular-dolls-allow.md new file mode 100644 index 00000000000..a0c2eca00b8 --- /dev/null +++ b/.changeset/popular-dolls-allow.md @@ -0,0 +1,5 @@ +--- +"@smithy/node-http-handler": minor +--- + +Fix constructor socketAcquisitionWarningTimeout does not work diff --git a/packages/node-http-handler/src/node-http-handler.ts b/packages/node-http-handler/src/node-http-handler.ts index a27a986609c..2836866fb58 100644 --- a/packages/node-http-handler/src/node-http-handler.ts +++ b/packages/node-http-handler/src/node-http-handler.ts @@ -122,13 +122,14 @@ or increase socketAcquisitionWarningTimeout=(millis) in the NodeHttpHandler conf } private resolveDefaultConfig(options?: NodeHttpHandlerOptions | void): ResolvedNodeHttpHandlerConfig { - const { requestTimeout, connectionTimeout, socketTimeout, httpAgent, httpsAgent } = options || {}; + const { requestTimeout, connectionTimeout, socketTimeout, socketAcquisitionWarningTimeout, httpAgent, httpsAgent } = options || {}; const keepAlive = true; const maxSockets = 50; return { connectionTimeout, requestTimeout: requestTimeout ?? socketTimeout, + socketAcquisitionWarningTimeout, httpAgent: (() => { if (httpAgent instanceof hAgent || typeof (httpAgent as hAgent)?.destroy === "function") { return httpAgent as hAgent; From 0fbf73ae890fa1578156d3be35e0daec83418ecd Mon Sep 17 00:00:00 2001 From: yuji-hatakeyama Date: Sun, 23 Feb 2025 16:49:58 +0900 Subject: [PATCH 2/3] style(node-http-handler): fix code format --- packages/node-http-handler/src/node-http-handler.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/node-http-handler/src/node-http-handler.ts b/packages/node-http-handler/src/node-http-handler.ts index 2836866fb58..69e71181e7e 100644 --- a/packages/node-http-handler/src/node-http-handler.ts +++ b/packages/node-http-handler/src/node-http-handler.ts @@ -122,7 +122,8 @@ or increase socketAcquisitionWarningTimeout=(millis) in the NodeHttpHandler conf } private resolveDefaultConfig(options?: NodeHttpHandlerOptions | void): ResolvedNodeHttpHandlerConfig { - const { requestTimeout, connectionTimeout, socketTimeout, socketAcquisitionWarningTimeout, httpAgent, httpsAgent } = options || {}; + const { requestTimeout, connectionTimeout, socketTimeout, socketAcquisitionWarningTimeout, httpAgent, httpsAgent } = + options || {}; const keepAlive = true; const maxSockets = 50; From a40c209179d22c84eae3622b95fc38f3cad7cb98 Mon Sep 17 00:00:00 2001 From: George Fu Date: Mon, 24 Feb 2025 11:14:37 -0800 Subject: [PATCH 3/3] set increment to patch --- .changeset/popular-dolls-allow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/popular-dolls-allow.md b/.changeset/popular-dolls-allow.md index a0c2eca00b8..f2ce7d723c6 100644 --- a/.changeset/popular-dolls-allow.md +++ b/.changeset/popular-dolls-allow.md @@ -1,5 +1,5 @@ --- -"@smithy/node-http-handler": minor +"@smithy/node-http-handler": patch --- Fix constructor socketAcquisitionWarningTimeout does not work