[Lambda] Fix termination for lambda (#3410)

* Fix termination for lambda

* format

Author: Michaelvll

sky/clouds/lambda_cloud.py

@@ -280,6 +280,7 @@ def query_status(cls, name: str, tag_filters: Dict[str, str],
             'booting': status_lib.ClusterStatus.INIT,
             'active': status_lib.ClusterStatus.UP,
             'unhealthy': status_lib.ClusterStatus.INIT,
+            'terminating': None,
             'terminated': None,
         }
         # TODO(ewzeng): filter by hash_filter_string to be safe

sky/skylet/providers/lambda_cloud/node_provider.py

@@ -152,7 +152,7 @@ def _match_tags(vm: Dict[str, Any]):
         def _get_internal_ip(node: Dict[str, Any]):
             # TODO(ewzeng): cache internal ips in metadata file to reduce
             # ssh overhead.
-            if node['external_ip'] is None:
+            if node['external_ip'] is None or node['status'] != 'active':
                 node['internal_ip'] = None
                 return
             runner = command_runner.SSHCommandRunner(node['external_ip'],
@@ -172,6 +172,10 @@ def _get_internal_ip(node: Dict[str, Any]):
         self.metadata.refresh([node['id'] for node in vms])
         self._guess_and_add_missing_tags(vms)
         nodes = [_extract_metadata(vm) for vm in filter(_match_tags, vms)]
+        nodes = [
+            node for node in nodes
+            if node['status'] not in ['terminating', 'terminated']
+        ]
         subprocess_utils.run_in_parallel(_get_internal_ip, nodes)
         self.cached_nodes = {node['id']: node for node in nodes}
         return self.cached_nodes