Skip to content

File name should match class name #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gynet opened this issue Dec 9, 2017 · 3 comments
Closed

File name should match class name #78

gynet opened this issue Dec 9, 2017 · 3 comments
Labels

Comments

@gynet
Copy link

gynet commented Dec 9, 2017

Currently, each file got named as "[problem].java". However, they use "Solution" as the class name in the content.

Is that better to change the file name to be "Solution.java" to keep it matching the class name?
Otherwise, the java file is not compilable...

I think we can put each problem into a separate folder named the same as the problem.

@gynet gynet changed the title File name match class name File name should match class name Dec 9, 2017
@skygragon
Copy link
Owner

skygragon commented Dec 13, 2017

Yep this because the code we generated is only a code snippet, instead of a complete source file that could be run or compiled locally. It's exactly what leetcode.com need as the input.

That's why 3rd party plugins are provided to fulfill advanced requirement, e.g. this plugin is used to run c++ code locally without sending it to leetcode.com.

@gynet
Copy link
Author

gynet commented Dec 13, 2017

Any plan for Java?

@skygragon
Copy link
Owner

move to skygragon/leetcode-cli-plugins#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants