From 03ca6efb9a58763f34ebb76e317de220d8a20139 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sun, 16 Jul 2023 11:54:57 +0200 Subject: [PATCH] GH Actions: update for php-coveralls 2.6.0 PHP-Coveralls 2.6.0 has just been released and includes a fix for the last known PHP 8.x issue. This means that it should now be safe to install php-coveralls on PHP 8.x and upload from there, which means we now only need the work-around for the PHP version when on PHP < 5.5 (as Coveralls v1 does not work with GH Actions). Ref: * https://github.com/php-coveralls/php-coveralls/releases/tag/v2.6.0 --- .github/workflows/test.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 25afa1b..1da3e50 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -190,18 +190,18 @@ jobs: if: ${{ steps.phpunit_version.outputs.VERSION >= '9.3' }} run: composer coverage -- --coverage-cache ./build/phpunit-cache - # PHP Coveralls v2 has a PHP 5.5 minimum and is not yet fully compatible with PHP 8.0+, so switch the PHP version. - - name: Switch to PHP 7.4 - if: ${{ success() && matrix.php != '7.4' }} + # PHP Coveralls v2 has a PHP 5.5 minimum, so switch the PHP version. + - name: Switch to PHP latest + if: ${{ success() && matrix.php == '5.4' }} uses: shivammathur/setup-php@v2 with: - php-version: 7.4 + php-version: 'latest' coverage: none - # Global install is used to prevent a conflict with the local composer.lock in PHP 8.0+. + # Global install is used to prevent a conflict with the local composer.lock. - name: Install Coveralls if: ${{ success() }} - run: composer global require php-coveralls/php-coveralls:"^2.5.3" --no-interaction --with-all-dependencies + run: composer global require php-coveralls/php-coveralls:"^2.6.0" --no-interaction --with-all-dependencies - name: Upload coverage results to Coveralls if: ${{ success() }}