-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: Incorporate new workflows and actions #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
we'll keep Simatic.Ax as namespace suggestion |
|
use Simatic.Ax namespace |
done |
| If you want to create a new application inside the GitHub community, you may use this apax template by entering the following command in the terminal: | ||
|
|
||
| ```bash | ||
| apax create @simatic-ax/app --registry https://npm.pkg.github.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| apax create @simatic-ax/app --registry https://npm.pkg.github.com | |
| apax create @simatic-ax/template-app --registry https://npm.pkg.github.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that this has to be corrected also in the template-lib readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope: 'apax create @simatic-ax/app' is correct
| apax create @simatic-ax/app --registry https://npm.pkg.github.com | ||
| ``` | ||
|
|
||
| ## Folder-structure of this "app" apax-template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Folder-structure of this "app" apax-template | |
| ## Folder-structure of this "template-app" apax-template |
| | |- package-development-workflow.yml | ||
| | |- package-release-workflow.yml | ||
| | | ||
| +-- template # the content that is going to be installed when using @simatic-ax/app during an apax create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| +-- template # the content that is going to be installed when using @simatic-ax/app during an apax create | |
| +-- template # the content that is going to be installed when using @simatic-ax/template-app during an apax create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simatic-ax/app is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past the prefix template- was required for the package name. And not in the create command. 100% sure. Let's clarify if, what and when it has changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add following into the apax.yml (not the apax.yml in the template folder)
keywords:
- "template"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spoken with the colleagues. The keyword app is exclusively occupied by the SIMATIC AX apax template. From the beginning, they've implemented an automatism, that would prefix any template name with template- during the apax create process, such that collisions with apax create app aren't happening. Given their response the current behavior (renaming app to template-app during apax create) is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, renaming behaviour is correct (comfort implementation) ... but what is our decision now ?
When it comes down to documentation it may be feels "strange/confusing" talking about "app" although the actual used name is "template-app".
FYI: added the keyword section as jürgen stated

No description provided.