Fix double-indirection bug in logging IDs (go-gitea#12294) (go-gitea#12308)

techknowlogick · zeripath · web-flow · commit 8d1cd4d2523d · 2020-07-24T02:24:22.000+03:00
This PR fixes a bug in log.NewColoredIDValue() which led to a double
indirection and incorrect IDs being printed out.

Signed-off-by: Andrew Thornton &lt;art27@cantab.net&gt;

Co-authored-by: zeripath &lt;art27@cantab.net&gt;
diff --git a/modules/log/colors.go b/modules/log/colors.go
@@ -355,7 +355,7 @@ func NewColoredValueBytes(value interface{}, colorBytes *[]byte) *ColoredValue {
 // The Value will be colored with FgCyan
 // If a ColoredValue is provided it is not changed
 func NewColoredIDValue(value interface{}) *ColoredValue {
-	return NewColoredValueBytes(&value, &fgCyanBytes)
+	return NewColoredValueBytes(value, &fgCyanBytes)
 }
 
 // Format will format the provided value and protect against ANSI color spoofing within the value

Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ func NewColoredValueBytes(value interface{}, colorBytes []byte) ColoredValue {`
`355`	`355`	`// The Value will be colored with FgCyan`
`356`	`356`	`// If a ColoredValue is provided it is not changed`
`357`	`357`	`func NewColoredIDValue(value interface{}) *ColoredValue {`
`358`		`- return NewColoredValueBytes(&value, &fgCyanBytes)`
	`358`	`+ return NewColoredValueBytes(value, &fgCyanBytes)`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`// Format will format the provided value and protect against ANSI color spoofing within the value`