Revert "betterproto: avoid assigning a var of type Optional[InclusionPromise] to TransparencyLogEntry.inclusion_promise"

This reverts commit 46b0087.

Signed-off-by: Ramon Petgrave <[email protected]>

Author: ramonpetgrave64

CHANGELOG.md

@@ -10,8 +10,6 @@ All versions prior to 0.9.0 are untracked.
 
 ### Fixed
 
-* Avoid pydantic's instantiation issues with `TransparencyLogEntry` when `InclusionPromise` is not present.
-
 * TSA: Changed the Timestamp Authority requests to explicitly use sha256 for message digests.
   [#1373](https://github.com/sigstore/sigstore-python/pull/1373)
 

sigstore/models.py

@@ -243,6 +243,12 @@ def _to_rekor(self) -> rekor_v1.TransparencyLogEntry:
 
         @private
         """
+        inclusion_promise: rekor_v1.InclusionPromise | None = None
+        if self.inclusion_promise:
+            inclusion_promise = rekor_v1.InclusionPromise(
+                signed_entry_timestamp=base64.b64decode(self.inclusion_promise)
+            )
+
         inclusion_proof = rekor_v1.InclusionProof(
             log_index=self.inclusion_proof.log_index,
             root_hash=bytes.fromhex(self.inclusion_proof.root_hash),
@@ -255,14 +261,10 @@ def _to_rekor(self) -> rekor_v1.TransparencyLogEntry:
             log_index=self.log_index,
             log_id=common_v1.LogId(key_id=bytes.fromhex(self.log_id)),
             integrated_time=self.integrated_time,
+            inclusion_promise=inclusion_promise,  # type: ignore[arg-type]
             inclusion_proof=inclusion_proof,
             canonicalized_body=base64.b64decode(self.body),
         )
-        if self.inclusion_promise:
-            inclusion_promise = rekor_v1.InclusionPromise(
-                signed_entry_timestamp=base64.b64decode(self.inclusion_promise)
-            )
-            tlog_entry.inclusion_promise = inclusion_promise
 
         # Fill in the appropriate kind
         body_entry: ProposedEntry = TypeAdapter(ProposedEntry).validate_json(