Skip to content

Commit 551a497

Browse files
authored
action: remove old output settings (#146)
* action: remove old output settings Signed-off-by: William Woodruff <[email protected]> * selftest: remove old test ref Signed-off-by: William Woodruff <[email protected]> --------- Signed-off-by: William Woodruff <[email protected]>
1 parent 16fbe9a commit 551a497

File tree

4 files changed

+0
-130
lines changed

4 files changed

+0
-130
lines changed

.github/workflows/selftest.yml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -256,27 +256,6 @@ jobs:
256256
[[ -f ./artifact.txt.sigstore.json ]] || exit 1
257257
working-directory: ./test/uploaded
258258

259-
selftest-custom-paths:
260-
runs-on: ubuntu-latest
261-
if: (github.event_name != 'pull_request') || !github.event.pull_request.head.repo.fork
262-
steps:
263-
- uses: actions/checkout@v4
264-
- name: Sign artifact and publish signature
265-
uses: ./
266-
id: sigstore-python
267-
with:
268-
inputs: ./test/artifact.txt
269-
signature: ./test/custom_signature.sig
270-
certificate: ./test/custom_certificate.crt
271-
bundle: ./test/custom_bundle.sigstore
272-
staging: true
273-
internal-be-careful-debug: true
274-
- name: Check outputs
275-
run: |
276-
[[ -f ./test/custom_signature.sig ]] || exit 1
277-
[[ -f ./test/custom_certificate.crt ]] || exit 1
278-
[[ -f ./test/custom_bundle.sigstore ]] || exit 1
279-
280259
selftest-verify:
281260
runs-on: ubuntu-latest
282261
if: (github.event_name != 'pull_request') || !github.event.pull_request.head.repo.fork
@@ -376,7 +355,6 @@ jobs:
376355
- selftest-glob
377356
- selftest-glob-multiple
378357
- selftest-upload-artifacts
379-
- selftest-custom-paths
380358
- selftest-verify
381359
- selftest-xfail-verify-missing-options
382360
- selftest-identity-token

README.md

Lines changed: 0 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -128,81 +128,6 @@ Example:
128128
oidc-client-secret: alternative-sigstore-secret
129129
```
130130

131-
### `signature`
132-
133-
**Default**: Empty (signature files will get named as `{input}.sig`)
134-
135-
The `signature` setting controls the name of the output signature file. This setting does not work
136-
when signing multiple input files.
137-
138-
Example:
139-
140-
```yaml
141-
- uses: sigstore/[email protected]
142-
with:
143-
inputs: file.txt
144-
signature: custom-signature-filename.sig
145-
```
146-
147-
However, this example is invalid:
148-
149-
```yaml
150-
- uses: sigstore/[email protected]
151-
with:
152-
inputs: file0.txt file1.txt file2.txt
153-
signature: custom-signature-filename.sig
154-
```
155-
156-
### `certificate`
157-
158-
**Default**: Empty (certificate files will get named as `{input}.crt`)
159-
160-
The `certificate` setting controls the name of the output certificate file. This setting does not
161-
work when signing multiple input files.
162-
163-
Example:
164-
165-
```yaml
166-
- uses: sigstore/[email protected]
167-
with:
168-
inputs: file.txt
169-
certificate: custom-certificate-filename.crt
170-
```
171-
172-
However, this example is invalid:
173-
174-
```yaml
175-
- uses: sigstore/[email protected]
176-
with:
177-
inputs: file0.txt file1.txt file2.txt
178-
certificate: custom-certificate-filename.crt
179-
```
180-
181-
### `bundle`
182-
183-
**Default**: Empty (bundle files will get named as `{input}.sigstore`)
184-
185-
The `bundle` setting controls the name of the output Sigstore bundle. This setting does not work
186-
when signing multiple input files.
187-
188-
Example:
189-
190-
```yaml
191-
- uses: sigstore/[email protected]
192-
with:
193-
inputs: file.txt
194-
bundle: custom-bundle.sigstore
195-
```
196-
197-
However, this example is invalid:
198-
199-
```yaml
200-
- uses: sigstore/[email protected]
201-
with:
202-
inputs: file0.txt file1.txt file2.txt
203-
certificate: custom-bundle.sigstore
204-
```
205-
206131
### `staging`
207132

208133
**Default**: `false`

action.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -146,24 +146,6 @@ def _fatal_help(msg):
146146
if client_secret:
147147
sigstore_sign_args.extend(["--oidc-client-secret", client_secret])
148148

149-
signature = os.getenv("GHA_SIGSTORE_PYTHON_SIGNATURE")
150-
if signature:
151-
sigstore_sign_args.extend(["--signature", signature])
152-
sigstore_verify_args.extend(["--signature", signature])
153-
signing_artifact_paths.append(signature)
154-
155-
certificate = os.getenv("GHA_SIGSTORE_PYTHON_CERTIFICATE")
156-
if certificate:
157-
sigstore_sign_args.extend(["--certificate", certificate])
158-
sigstore_verify_args.extend(["--certificate", certificate])
159-
signing_artifact_paths.append(certificate)
160-
161-
bundle = os.getenv("GHA_SIGSTORE_PYTHON_BUNDLE")
162-
if bundle:
163-
sigstore_sign_args.extend(["--bundle", bundle])
164-
sigstore_verify_args.extend(["--bundle", bundle])
165-
signing_artifact_paths.append(bundle)
166-
167149
if os.getenv("GHA_SIGSTORE_PYTHON_STAGING", "false") != "false":
168150
sigstore_global_args.append("--staging")
169151

action.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,6 @@ inputs:
3232
description: "the custom OpenID Connect client secret to use during OAuth2"
3333
required: false
3434
default: ""
35-
signature:
36-
description: "write a single signature to the given file; does not work with multiple input files"
37-
required: false
38-
default: ""
39-
certificate:
40-
description: "write a single certificate to the given file; does not work with multiple input files"
41-
required: false
42-
default: ""
43-
bundle:
44-
description: "write a single Sigstore bundle to the given file; does not work with multiple input files"
45-
required: false
46-
default: ""
4735
staging:
4836
description: "use sigstore's staging instances, instead of the default production instances"
4937
required: false
@@ -102,9 +90,6 @@ runs:
10290
PYTHONUTF8: "1"
10391
VENV_PYTHON_PATH: "${{ steps.setup.outputs.venv-python-path }}"
10492
GHA_SIGSTORE_PYTHON_IDENTITY_TOKEN: "${{ inputs.identity-token }}"
105-
GHA_SIGSTORE_PYTHON_SIGNATURE: "${{ inputs.signature }}"
106-
GHA_SIGSTORE_PYTHON_CERTIFICATE: "${{ inputs.certificate }}"
107-
GHA_SIGSTORE_PYTHON_BUNDLE: "${{ inputs.bundle }}"
10893
GHA_SIGSTORE_PYTHON_OIDC_CLIENT_ID: "${{ inputs.oidc-client-id }}"
10994
GHA_SIGSTORE_PYTHON_OIDC_CLIENT_SECRET: "${{ inputs.oidc-client-secret }}"
11095
GHA_SIGSTORE_PYTHON_STAGING: "${{ inputs.staging }}"

0 commit comments

Comments
 (0)