Shutter API Keyper basic test setup #604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blockchainluffy
requested review from
jannikluhn,
konradkonrad,
ulope and
ylembachar
Contributor
|
There is a lot of duplication between this and the existing snapshot setup. Is there a reason why we can't reuse most of the existing code? I suspect the only difference are a few parameters that we could set with a docker compose override file (or in the worst case separate docker compose files). Also, when I try to run it, it seems to be missing some environment variables (private keys, contract addresses, parameters). I suspect we can hardcode most of them and if necessary add a Thoughts @ulope? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #568