From 93be771ffd9fbf6b215a1b3e8775df59f704373b Mon Sep 17 00:00:00 2001 From: Christer Date: Tue, 21 Oct 2025 08:54:10 +0200 Subject: [PATCH 1/2] fix(config): User friendly value formatting of Dir and File options --- .../config/lib/src/config/file_system_options.dart | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/packages/config/lib/src/config/file_system_options.dart b/packages/config/lib/src/config/file_system_options.dart index c553ef3..22a35c4 100644 --- a/packages/config/lib/src/config/file_system_options.dart +++ b/packages/config/lib/src/config/file_system_options.dart @@ -1,6 +1,7 @@ import 'dart:io'; import 'package:args/command_runner.dart'; +import 'package:path/path.dart' as p; import 'options.dart'; @@ -17,6 +18,12 @@ class DirParser extends ValueParser { Directory parse(final String value) { return Directory(value); } + + @override + String format(final Directory value) { + final path = value.path; + return path.endsWith(p.separator) ? path : '$path${p.separator}'; + } } /// Directory path configuration option. @@ -81,6 +88,11 @@ class FileParser extends ValueParser { File parse(final String value) { return File(value); } + + @override + String format(final File value) { + return value.path; + } } /// File path configuration option. From 0019d368eef4069684bbbbda8f32a38a8f359670 Mon Sep 17 00:00:00 2001 From: Christer Date: Tue, 21 Oct 2025 19:32:39 +0200 Subject: [PATCH 2/2] docs(config): Fixed doc comment warnings --- packages/config/lib/src/config/option_types.dart | 2 +- packages/config/lib/src/config/options.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/config/lib/src/config/option_types.dart b/packages/config/lib/src/config/option_types.dart index 5387459..7dabdc6 100644 --- a/packages/config/lib/src/config/option_types.dart +++ b/packages/config/lib/src/config/option_types.dart @@ -251,7 +251,7 @@ class IntOption extends ComparableValueOption { /// /// This implementation is more forgiving than [DateTime.parse]. /// In addition to the standard T and space separators between -/// date and time it also allows [-_/:t]. +/// date and time it also allows \[-_/:t\]. class DateTimeParser extends ValueParser { const DateTimeParser(); diff --git a/packages/config/lib/src/config/options.dart b/packages/config/lib/src/config/options.dart index 83b7e6b..00d0bad 100644 --- a/packages/config/lib/src/config/options.dart +++ b/packages/config/lib/src/config/options.dart @@ -3,7 +3,7 @@ import 'package:args/command_runner.dart'; import 'package:collection/collection.dart'; import 'package:meta/meta.dart'; -import 'configuration.dart'; +import 'configuration.dart' show Configuration; import 'configuration_broker.dart'; import 'exceptions.dart'; import 'option_resolution.dart';