Skip to content

An error is raised when generating a png #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JBBianchi opened this issue Feb 29, 2024 · 0 comments · Fixed by #26
Closed

An error is raised when generating a png #27

JBBianchi opened this issue Feb 29, 2024 · 0 comments · Fixed by #26
Assignees
Labels
bug Something isn't working

Comments

@JBBianchi
Copy link
Member

What happened:
Generating a png for a workflow seems to throw an error under certain conditions:
image

What you expected to happen:
The png to be generated.

How to reproduce it:

  • Create a workflow.json file containing:
{
  "id": "helloworld",
  "version": "1.0.0",
  "specVersion": "0.8",
  "name": "Hello World Workflow",
  "description": "Inject Hello World",
  "start": "hello state",
  "states": [
     {
        "name": "hello state",
        "type": "inject",
        "data": {
           "result": "Hello World!"
        },
        "end": true
     }
  ]
}
  • ctrl+shift+p > Export Diagram to PNG (or Generate Diagram, will also fail)

Anything else we need to know?:
From Saad Ansari on Slack

It seems to be related to a incorrect handling of paths and/or expected inputs of the command.

The extension also relies on external services to generate the files which is not necessary as VSCode already packs browser's capatiblities to render the diagram.

Finally, the code base is scattered and difficult to debug.

Environment:
Tested on Win11 x64. Reported from MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants