Semantic inconsistencies between listen and emit tasks

[cdavernas]

What seems off:

The listen task allows for user to configure events to listen to in the following way:

listen:
  to:
    one:
      with: {}

Whereas the emit task does not define the with keyword:

emit:
  event: {}

What you expected to be:

The emit task to define a with keyword, use to define event properties:

emit:
  event:
    with: {}

This would allow for potential future properties such as format, and would make it more fluent, ubiquitous and consistent.

[cdavernas]

@ricardozanini @matthias-pichler-warrify @fjtirado What do you guys think? Should I proceed with it?

[fjtirado]

@fjtirado
I would actually remove with from listen ;), have you considered that approach?

[fjtirado]

But yes, if you want to keep with on listen, it makes sense to add it to emit in order to make it symmetric.

[fjtirado]

Ok, correcting myself (I did not see the format point) yes, lets add with both for emit and listen.
Which Im not sure is the usefulness of to: maybe we can just have

listen:
   one: 
      with: 

emit: 
  event:
    with:

[JBBianchi]

(Just a side note, there is a dead link in emit in the column Type, on the word "event" --> https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#event)

[cdavernas]

@fjtirado tbh it's mostly for aestetics and semantics that I thought of adding the with, even though, I can see new props making it there in a close future.

[cdavernas]

@JBBianchi good catch! Would you be so kind to open a PR to fix it?

[JBBianchi]

@JBBianchi good catch! Would you be so kind to open a PR to fix it?

I think this can be tackled at the same time than the current topic. That being said, I can open a PR once we agree on the direction we want to take.