Skip to content

Group End and Transition properties #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdavernas opened this issue Sep 16, 2022 · 8 comments
Closed

Group End and Transition properties #684

cdavernas opened this issue Sep 16, 2022 · 8 comments
Assignees
Labels
change: feature New feature or request. Impacts in a minor version change
Milestone

Comments

@cdavernas
Copy link
Member

What would you like to be added:
Group End and Transition properties, in such way that we can address it as an (activity | state | workflow) outcome.

In other words, what I'd like to achieve is:

...
states:
  - name: MyState
    outcome:
      type: end
      produceEvents: ...
    ...
...

Why is this needed:

Because End and Transition properties are mutually exclusive, and implicitly defines the outcome of an (activity | state | workflow), it makes sense to call is as such. In addition, it simplifies processing of the whole definition, by checking that an outcome has been specified instead of having to do checks on multiple properties. @tsurdilo WDYT?

@tsurdilo
Copy link
Contributor

Yes, i wish we did this to begin with. Will update

@tsurdilo tsurdilo self-assigned this Sep 16, 2022
@tsurdilo tsurdilo added the change: feature New feature or request. Impacts in a minor version change label Sep 16, 2022
@tsurdilo tsurdilo added this to the v0.9 milestone Sep 16, 2022
@cdavernas
Copy link
Member Author

I'm working on it, PR should be ready by Monday;)

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@lsytj0413
Copy link
Contributor

/remove-stale

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as completed Apr 5, 2023
@ricardozanini ricardozanini reopened this Apr 27, 2023
@ricardozanini ricardozanini assigned cdavernas and unassigned tsurdilo May 25, 2023
@cdavernas cdavernas linked a pull request May 30, 2023 that will close this issue
5 tasks
@cdavernas cdavernas moved this from Todo to In Progress in Progress Tracker May 30, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cdavernas
Copy link
Member Author

cdavernas commented May 17, 2024

Closed as resolved by 1.0.0-alpha1, and therefore as part of #843

@github-project-automation github-project-automation bot moved this from In Progress to Done in Progress Tracker May 17, 2024
This was referenced May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change: feature New feature or request. Impacts in a minor version change
Projects
Status: Done
4 participants