fix-remove-default-values

Signed-off-by: Antonio Mendoza Pérez <[email protected]>

Author: antmendoza

src/lib/builders/action-builder.ts

@@ -27,7 +27,7 @@ function actionBuildingFn(data: Specification.Action): () => Specification.Actio
   return () => {
     const model = new Specification.Action(data);
 
-    validate('Action', model);
+    validate('Action', model.normalize());
     return model;
   };
 }

src/lib/builders/authdef-builder.ts

@@ -27,7 +27,7 @@ function authdefBuildingFn(data: Specification.Authdef): () => Specification.Aut
   return () => {
     const model = new Specification.Authdef(data);
 
-    validate('Authdef', model);
+    validate('Authdef', model.normalize());
     return model;
   };
 }

src/lib/builders/branch-builder.ts

@@ -27,7 +27,7 @@ function branchBuildingFn(data: Specification.Branch): () => Specification.Branc
   return () => {
     const model = new Specification.Branch(data);
 
-    validate('Branch', model);
+    validate('Branch', model.normalize());
     return model;
   };
 }

src/lib/builders/callbackstate-builder.ts

@@ -30,7 +30,7 @@ function callbackstateBuildingFn(data: Specification.Callbackstate): () => Speci
 
     setEndValueIfNoTransition(model);
 
-    validate('Callbackstate', model);
+    validate('Callbackstate', model.normalize());
     return model;
   };
 }

src/lib/builders/continueasdef-builder.ts

@@ -27,7 +27,7 @@ function continueasdefBuildingFn(data: Specification.Continueasdef): () => Speci
   return () => {
     const model = new Specification.Continueasdef(data);
 
-    validate('Continueasdef', model);
+    validate('Continueasdef', model.normalize());
     return model;
   };
 }

src/lib/builders/databasedswitchstate-builder.ts

@@ -29,7 +29,7 @@ function databasedswitchstateBuildingFn(
   return () => {
     const model = new Specification.Databasedswitchstate(data);
 
-    validate('Databasedswitchstate', model);
+    validate('Databasedswitchstate', model.normalize());
     return model;
   };
 }

src/lib/builders/defaultconditiondef-builder.ts

@@ -29,7 +29,7 @@ function defaultconditiondefBuildingFn(
   return () => {
     const model = new Specification.Defaultconditiondef(data);
 
-    validate('Defaultconditiondef', model);
+    validate('Defaultconditiondef', model.normalize());
     return model;
   };
 }

src/lib/builders/end-builder.ts

@@ -27,7 +27,7 @@ function endBuildingFn(data: Specification.End): () => Specification.End {
   return () => {
     const model = new Specification.End(data);
 
-    validate('End', model);
+    validate('End', model.normalize());
     return model;
   };
 }

src/lib/builders/enddatacondition-builder.ts

@@ -27,7 +27,7 @@ function enddataconditionBuildingFn(data: Specification.Enddatacondition): () =>
   return () => {
     const model = new Specification.Enddatacondition(data);
 
-    validate('Enddatacondition', model);
+    validate('Enddatacondition', model.normalize());
     return model;
   };
 }

src/lib/builders/enddeventcondition-builder.ts

@@ -27,7 +27,7 @@ function enddeventconditionBuildingFn(data: Specification.Enddeventcondition): (
   return () => {
     const model = new Specification.Enddeventcondition(data);
 
-    validate('Enddeventcondition', model);
+    validate('Enddeventcondition', model.normalize());
     return model;
   };
 }

src/lib/builders/error-builder.ts

@@ -30,7 +30,7 @@ function errorBuildingFn(data: Specification.Error): () => Specification.Error {
 
     setEndValueIfNoTransition(model);
 
-    validate('Error', model);
+    validate('Error', model.normalize());
     return model;
   };
 }

src/lib/builders/eventbasedswitchstate-builder.ts

@@ -29,7 +29,7 @@ function eventbasedswitchstateBuildingFn(
   return () => {
     const model = new Specification.Eventbasedswitchstate(data);
 
-    validate('Eventbasedswitchstate', model);
+    validate('Eventbasedswitchstate', model.normalize());
     return model;
   };
 }

src/lib/builders/eventdef-builder.ts

@@ -27,7 +27,7 @@ function eventdefBuildingFn(data: Specification.Eventdef): () => Specification.E
   return () => {
     const model = new Specification.Eventdef(data);
 
-    validate('Eventdef', model);
+    validate('Eventdef', model.normalize());
     return model;
   };
 }

src/lib/builders/eventref-builder.ts

@@ -27,7 +27,7 @@ function eventrefBuildingFn(data: Specification.Eventref): () => Specification.E
   return () => {
     const model = new Specification.Eventref(data);
 
-    validate('Eventref', model);
+    validate('Eventref', model.normalize());
     return model;
   };
 }

src/lib/builders/eventstate-builder.ts

@@ -30,7 +30,7 @@ function eventstateBuildingFn(data: Specification.Eventstate): () => Specificati
 
     setEndValueIfNoTransition(model);
 
-    validate('Eventstate', model);
+    validate('Eventstate', model.normalize());
     return model;
   };
 }

src/lib/builders/foreachstate-builder.ts

@@ -30,7 +30,7 @@ function foreachstateBuildingFn(data: Specification.Foreachstate): () => Specifi
 
     setEndValueIfNoTransition(model);
 
-    validate('Foreachstate', model);
+    validate('Foreachstate', model.normalize());
     return model;
   };
 }

src/lib/builders/function-builder.ts

@@ -27,7 +27,7 @@ function functionBuildingFn(data: Specification.Function): () => Specification.F
   return () => {
     const model = new Specification.Function(data);
 
-    validate('Function', model);
+    validate('Function', model.normalize());
     return model;
   };
 }

src/lib/builders/functionref-builder.ts

@@ -27,7 +27,7 @@ function functionrefBuildingFn(data: Specification.Functionref): () => Specifica
   return () => {
     const model = new Specification.Functionref(data);
 
-    validate('Functionref', model);
+    validate('Functionref', model.normalize());
     return model;
   };
 }

src/lib/builders/injectstate-builder.ts

@@ -30,7 +30,7 @@ function injectstateBuildingFn(data: Specification.Injectstate): () => Specifica
 
     setEndValueIfNoTransition(model);
 
-    validate('Injectstate', model);
+    validate('Injectstate', model.normalize());
     return model;
   };
 }

src/lib/builders/onevents-builder.ts

@@ -27,7 +27,7 @@ function oneventsBuildingFn(data: Specification.Onevents): () => Specification.O
   return () => {
     const model = new Specification.Onevents(data);
 
-    validate('Onevents', model);
+    validate('Onevents', model.normalize());
     return model;
   };
 }

src/lib/builders/operationstate-builder.ts

@@ -30,7 +30,7 @@ function operationstateBuildingFn(data: Specification.Operationstate): () => Spe
 
     setEndValueIfNoTransition(model);
 
-    validate('Operationstate', model);
+    validate('Operationstate', model.normalize());
     return model;
   };
 }

src/lib/builders/parallelstate-builder.ts

@@ -30,7 +30,7 @@ function parallelstateBuildingFn(data: Specification.Parallelstate): () => Speci
 
     setEndValueIfNoTransition(model);
 
-    validate('Parallelstate', model);
+    validate('Parallelstate', model.normalize());
     return model;
   };
 }

src/lib/builders/sleepstate-builder.ts

@@ -27,7 +27,7 @@ function sleepstateBuildingFn(data: Specification.Sleepstate): () => Specificati
   return () => {
     const model = new Specification.Sleepstate(data);
 
-    validate('Sleepstate', model);
+    validate('Sleepstate', model.normalize());
     return model;
   };
 }

src/lib/builders/subflowref-builder.ts

@@ -27,7 +27,7 @@ function subflowrefBuildingFn(data: Specification.Subflowref): () => Specificati
   return () => {
     const model = new Specification.Subflowref(data);
 
-    validate('Subflowref', model);
+    validate('Subflowref', model.normalize());
     return model;
   };
 }

src/lib/builders/timeouts-builder.ts

@@ -27,7 +27,7 @@ function timeoutsBuildingFn(data: Specification.Timeouts): () => Specification.T
   return () => {
     const model = new Specification.Timeouts(data);
 
-    validate('Timeouts', model);
+    validate('Timeouts', model.normalize());
     return model;
   };
 }

src/lib/builders/transition-builder.ts

@@ -27,7 +27,7 @@ function transitionBuildingFn(data: Specification.Transition): () => Specificati
   return () => {
     const model = new Specification.Transition(data);
 
-    validate('Transition', model);
+    validate('Transition', model.normalize());
     return model;
   };
 }

src/lib/builders/transitiondatacondition-builder.ts

@@ -29,7 +29,7 @@ function transitiondataconditionBuildingFn(
   return () => {
     const model = new Specification.Transitiondatacondition(data);
 
-    validate('Transitiondatacondition', model);
+    validate('Transitiondatacondition', model.normalize());
     return model;
   };
 }

src/lib/builders/transitioneventcondition-builder.ts

@@ -29,7 +29,7 @@ function transitioneventconditionBuildingFn(
   return () => {
     const model = new Specification.Transitioneventcondition(data);
 
-    validate('Transitioneventcondition', model);
+    validate('Transitioneventcondition', model.normalize());
     return model;
   };
 }

src/lib/builders/workflow-builder.ts

@@ -27,7 +27,7 @@ function workflowBuildingFn(data: Specification.Workflow): () => Specification.W
   return () => {
     const model = new Specification.Workflow(data);
 
-    validate('Workflow', model);
+    validate('Workflow', model.normalize());
     return model;
   };
 }

src/lib/builders/workflow-exec-timeout-builder.ts

@@ -29,7 +29,7 @@ function workflowExecTimeoutBuildingFn(
   return () => {
     const model = new Specification.WorkflowExecTimeout(data);
 
-    validate('WorkflowExecTimeout', model);
+    validate('WorkflowExecTimeout', model.normalize());
     return model;
   };
 }

src/lib/definitions/action.ts

@@ -17,6 +17,7 @@ import { Actiondatafilter } from './actiondatafilter';
 import { Eventref } from './eventref';
 import { Functionref } from './functionref';
 import {
+  cleanSourceModelProperty,
   normalizeEventRef,
   normalizeFunctionRef,
   normalizeSubFlowRefIfObject,
@@ -30,7 +31,11 @@ import { Subflowref } from './subflowref';
 import { Sleep } from './sleep';
 
 export class Action {
+  sourceModel?: Action;
+
   constructor(model: any) {
+    this.sourceModel = Object.assign({}, model);
+
     Object.assign(this, model);
 
     overwriteFunctionRefIfObject(this);
@@ -81,6 +86,8 @@ export class Action {
     normalizeEventRef(clone);
     normalizeFunctionRef(clone);
 
+    cleanSourceModelProperty(clone);
+
     return clone;
   };
 }

src/lib/definitions/authdef.ts

@@ -14,11 +14,15 @@
  * limitations under the License.
  */
 
-import { normalizeScheme, overwritePropertiesIfObject } from './utils';
+import { cleanSourceModelProperty, normalizeScheme, overwritePropertiesIfObject } from './utils';
 import { Properties } from './types';
 
 export class Authdef {
+  sourceModel?: Authdef;
+
   constructor(model: any) {
+    this.sourceModel = Object.assign({}, model);
+
     const defaultModel = { scheme: 'basic' };
     Object.assign(this, defaultModel, model);
 
@@ -41,7 +45,9 @@ export class Authdef {
   normalize = (): Authdef => {
     const clone = new Authdef(this);
 
-    normalizeScheme(clone);
+    normalizeScheme(clone, this.sourceModel);
+
+    cleanSourceModelProperty(clone);
 
     return clone;
   };

src/lib/definitions/branch.ts

@@ -15,11 +15,15 @@
  */
 
 import { Action } from './action';
-import { normalizeActions, overwriteActions, overwritePropertyAsPlainType } from './utils';
+import { cleanSourceModelProperty, normalizeActions, overwriteActions, overwritePropertyAsPlainType } from './utils';
 import { ActionExecTimeout, BranchExecTimeout } from './types';
 
 export class Branch /* Branch Definition */ {
+  sourceModel?: Branch;
+
   constructor(model: any) {
+    this.sourceModel = Object.assign({}, model);
+
     Object.assign(this, model);
     overwriteActions(this);
     overwritePropertyAsPlainType('timeouts', this);
@@ -43,12 +47,13 @@ export class Branch /* Branch Definition */ {
 
   /**
    * Normalize the value of each property by recursively deleting properties whose value is equal to its default value. Does not modify the object state.
-   * @returns {Specification.Action} without deleted properties.
+   * @returns {Specification.Branch} without deleted properties.
    */
   normalize = (): Branch => {
     const clone = new Branch(this);
     normalizeActions(clone);
 
+    cleanSourceModelProperty(clone);
     return clone;
   };
 }

src/lib/definitions/callbackstate.ts

@@ -22,6 +22,7 @@ import { Metadata } from './metadata';
 import { Statedatafilter } from './statedatafilter';
 import { Transition } from './transition';
 import {
+  cleanSourceModelProperty,
   normalizeAction,
   normalizeEndIfObject,
   normalizeOnErrors,
@@ -41,7 +42,11 @@ import { ActionExecTimeout, EventTimeout } from './types';
 import { StateExecTimeout } from './stateExecTimeout';
 
 export class Callbackstate {
+  sourceModel?: Callbackstate;
+
   constructor(model: any) {
+    this.sourceModel = Object.assign({}, model);
+
     const defaultModel = { type: 'callback', usedForCompensation: false };
     Object.assign(this, defaultModel, model);
 
@@ -124,9 +129,11 @@ export class Callbackstate {
     normalizeOnErrors(clone);
     normalizeTransitionIfObject(clone);
     normalizeEndIfObject(clone);
-    normalizeUsedForCompensation(clone);
+    normalizeUsedForCompensation(clone, this.sourceModel);
     setEndValueIfNoTransition(clone);
 
+    cleanSourceModelProperty(clone);
+
     return clone;
   };
 }