Skip to content

Commit cbb8ab0

Browse files
Apply suggestions from Javi's code review
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
1 parent 500c31b commit cbb8ab0

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

validation/src/main/java/io/serverlessworkflow/validation/WorkflowValidatorImpl.java

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -362,11 +362,7 @@ public WorkflowValidator reset() {
362362
private boolean isMissingFunctionDefinition(
363363
String functionName, List<FunctionDefinition> functions) {
364364
if (functions != null) {
365-
return functions.stream()
366-
.filter(f -> f.getName().equals(functionName))
367-
.findFirst()
368-
.orElse(null)
369-
== null;
365+
return !functions.stream().anyMatch(f -> f.getName().equals(functionName));
370366
} else {
371367
return true;
372368
}
@@ -377,23 +373,15 @@ private boolean isMissingEventsDefinition(String eventName, List<EventDefinition
377373
return false;
378374
}
379375
if (events != null) {
380-
return events.stream().filter(e -> e.getName().equals(eventName)).findFirst().orElse(null)
381-
== null;
376+
return !events.stream().anyMatch(e -> e.getName().equals(eventName));
382377
} else {
383378
return true;
384379
}
385380
}
386381

387382
private boolean isMissingRetryDefinition(String retryName, List<RetryDefinition> retries) {
388-
if (retries != null) {
389-
return retries.stream()
390-
.filter(f -> f.getName() != null && f.getName().equals(retryName))
391-
.findFirst()
392-
.orElse(null)
393-
== null;
394-
} else {
395-
return true;
396-
}
383+
return retries == null || ! retries.stream()
384+
.anyMatch(f -> f.getName() != null && f.getName().equals(retryName));
397385
}
398386

399387
private static final Set<String> skipMessages =

0 commit comments

Comments
 (0)