From 1218d17a3e4fd7c173ed4b82a2814675006a7081 Mon Sep 17 00:00:00 2001 From: Aleksandr Sobolev Date: Fri, 27 Oct 2017 03:14:47 +0600 Subject: [PATCH 1/2] Regarding #43 - Added PULL_REQUEST_TEMPLATE --- .github/PULL_REQUEST_TEMPLATE | 37 +++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE new file mode 100644 index 0000000..bbb4b00 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE @@ -0,0 +1,37 @@ + + +**Description of the change**: + +**Reason for the change**: + +**Link to original source**: + +### Checklist + +Make sure all of these items are complete, or else the PR will be ineligible for a code review. + +- [ ] Code passes all existing [tests](https://github.com/sendgrid/open-source-library-data-collector/tree/master/test) +- [ ] Any new functionality added includes new unit tests in [`tests/test.py`](https://github.com/sendgrid/open-source-library-data-collector/blob/master/test/test.py) +- [ ] Create or update example code to show the new functionality in action. +- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/open-source-library-data-collector/blob/master/CONTRIBUTING.md#style-guidelines--naming-conventions)) +- [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/open-source-library-data-collector/blob/master/CONTRIBUTING.md#creating-a-pull-request) ). + +If you have questions, please send an email [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository. + + From 939f5dbcd73adcfe2afd66bda158d9fa5f9eeee2 Mon Sep 17 00:00:00 2001 From: Aleksandr Sobolev Date: Fri, 27 Oct 2017 03:20:13 +0600 Subject: [PATCH 2/2] Regarding #43 - Simpify PULL_REQUEST_TEMPLATE --- .github/PULL_REQUEST_TEMPLATE | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index bbb4b00..229ad59 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -1,37 +1,5 @@ - - **Description of the change**: **Reason for the change**: -**Link to original source**: - -### Checklist - -Make sure all of these items are complete, or else the PR will be ineligible for a code review. - -- [ ] Code passes all existing [tests](https://github.com/sendgrid/open-source-library-data-collector/tree/master/test) -- [ ] Any new functionality added includes new unit tests in [`tests/test.py`](https://github.com/sendgrid/open-source-library-data-collector/blob/master/test/test.py) -- [ ] Create or update example code to show the new functionality in action. -- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/open-source-library-data-collector/blob/master/CONTRIBUTING.md#style-guidelines--naming-conventions)) -- [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/open-source-library-data-collector/blob/master/CONTRIBUTING.md#creating-a-pull-request) ). - -If you have questions, please send an email [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository. -