From 547df7a20198aeabcd03981a1921b0b83dcaaa50 Mon Sep 17 00:00:00 2001 From: themousepotato Date: Fri, 26 Oct 2018 19:20:31 +0530 Subject: [PATCH 1/2] refactor code #107 --- package_managers.py | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/package_managers.py b/package_managers.py index 4558268..19cc6eb 100644 --- a/package_managers.py +++ b/package_managers.py @@ -41,6 +41,8 @@ def update_package_manager_data(self, package_manager_urls): num_csharp_http_client_downloads = None num_php_http_client_downloads = None num_node_http_client_downloads = None + + check_dict = {} for url in package_manager_urls: if 'https://www.nuget.org/packages/SendGrid' == url: num_total_csharp_downloads = self.csharp_downloads(url) @@ -57,17 +59,22 @@ def update_package_manager_data(self, package_manager_urls): if 'https://packagist.org/packages/sendgrid/php-http-client' == \ url: num_php_http_client_downloads = self.php_downloads(url) - if 'pypi' in url and 'sendgrid' in url: - num_python_downloads = self.python_downloads(url) - if 'pypi' in url and 'python_http_client' in url: - num_python_http_client_downloads = self.python_downloads(url) - if 'pypi' in url and 'open_source_library_data_collector' in url: - num_python_open_source_library_data_collector_downloads = \ - self.python_downloads(url) - if 'rubygems' in url and 'sendgrid' in url: - num_ruby_downloads = self.ruby_downloads(url) - if 'rubygems' in url and 'http' in url: - num_ruby_http_client_downloads = self.ruby_downloads(url) + if 'pypi' in url: + if 'sendgrid' in url: + num_python_downloads = self.python_downloads(url) + if 'pypi' in url: + if 'python_http_client' in url: + num_python_http_client_downloads = self.python_downloads(url) + if 'pypi' in url: + if 'open_source_library_data_collector' in url: + num_python_open_source_library_data_collector_downloads = \ + self.python_downloads(url) + if 'rubygems' in url: + if 'sendgrid' in url: + num_ruby_downloads = self.ruby_downloads(url) + if 'rubygems' in url: + if 'http' in url: + num_ruby_http_client_downloads = self.ruby_downloads(url) return self.update_db( num_total_csharp_downloads, From 9db0b0765bbc897db8bbd0b7d6d01e802ed97f48 Mon Sep 17 00:00:00 2001 From: themousepotato Date: Sat, 27 Oct 2018 14:28:57 +0530 Subject: [PATCH 2/2] fixes --- package_managers.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package_managers.py b/package_managers.py index 19cc6eb..7c4115f 100644 --- a/package_managers.py +++ b/package_managers.py @@ -42,7 +42,6 @@ def update_package_manager_data(self, package_manager_urls): num_php_http_client_downloads = None num_node_http_client_downloads = None - check_dict = {} for url in package_manager_urls: if 'https://www.nuget.org/packages/SendGrid' == url: num_total_csharp_downloads = self.csharp_downloads(url) @@ -67,7 +66,7 @@ def update_package_manager_data(self, package_manager_urls): num_python_http_client_downloads = self.python_downloads(url) if 'pypi' in url: if 'open_source_library_data_collector' in url: - num_python_open_source_library_data_collector_downloads = \ + num_python_open_source_library_data_collector_downloads=\ self.python_downloads(url) if 'rubygems' in url: if 'sendgrid' in url: