Skip to content
This repository was archived by the owner on Aug 28, 2020. It is now read-only.

fixed Travis, converted README and version as file #138

Closed
wants to merge 5 commits into from
Closed

fixed Travis, converted README and version as file #138

wants to merge 5 commits into from

Conversation

StrikerRUS
Copy link

@StrikerRUS StrikerRUS commented Oct 9, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • [n/a] I have added necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

- fix tests and coverage by removing the check of existence of Dockerfile, docker-compose.yml, USE_CASES.md and using only codecov for coverage.

@SendGridDX
Copy link

SendGridDX commented Oct 9, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6dd1ae1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #138   +/-   ##
=========================================
  Coverage          ?   48.71%           
=========================================
  Files             ?        2           
  Lines             ?      156           
  Branches          ?        0           
=========================================
  Hits              ?       76           
  Misses            ?       80           
  Partials          ?        0
Impacted Files Coverage Δ
test/test_repository_files.py 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dd1ae1...f962c4f. Read the comment docs.

@StrikerRUS
Copy link
Author

Hi @thinkingserious !
You've asked me in sendgrid/python-http-client#93 (comment) to propose those changes in other SendGrid repos. This is the last one. Due to the README file replacement this PR has many conflicts with other open PRs. Is it possible to merge it first to avoid multiple branch rebases?

@StrikerRUS
Copy link
Author

Gentle ping @thinkingserious

@StrikerRUS
Copy link
Author

ping @thinkingserious

@StrikerRUS
Copy link
Author

Closed due to the disinterest.

@StrikerRUS StrikerRUS closed this Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants