Skip to content

Commit 94808d9

Browse files
author
Matt Bernier
authored
Update PULL_REQUEST_TEMPLATE
1 parent e302541 commit 94808d9

File tree

1 file changed

+17
-22
lines changed

1 file changed

+17
-22
lines changed

.github/PULL_REQUEST_TEMPLATE

Lines changed: 17 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,24 @@
1-
<!--
2-
Please explain WHAT you changed and WHY.
1+
<!--
2+
We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines given above, then fill out the blanks below.
33

4-
The title should be descriptive, for example:
54

6-
* *Fixed a typo in the apikeypermissions.md page*
7-
* *Added the maximum number of domain whitelabels you can create to domains.md*
8-
* *Fixing the number of days a batch id is valid in scheduling_parameters.md*
9-
10-
Fill out this form in the body:
11-
-->
12-
13-
**Description of the change**:
14-
**Reason for the change**:
15-
**Link to original source**:
16-
<!--
17-
If this pull request closes an issue, add in the issue number here
5+
Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged!
6+
e.g.
7+
Fixes #1
8+
Closes #2
189
-->
19-
Closes #
10+
# Fixes #
2011

2112
### Checklist
13+
- [ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
14+
- [ ] I have read the [Contribution Guide] and my PR follows them.
15+
- [ ] I updated my branch with the master branch.
16+
- [ ] I have added tests that prove my fix is effective or that my feature works
17+
- [ ] I have added necessary documentation about the functionality in the appropriate .md file
18+
- [ ] I have added in line documentation to the code I modified
2219

23-
Make sure all of these items are complete, or else the PR will be ineligible for a code review.
20+
### Short description of what this PR does:
21+
-
22+
-
2423

25-
- [ ] Code passes all existing [tests](https://github.com/sendgrid/csharp-http-client/tree/master/UnitTest)
26-
- [ ] Any new functionality added includes new unit tests
27-
- [ ] Create or update example code to show the new functionality in action.
28-
- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/csharp-http-client/blob/master/CONTRIBUTING.md#style-guidelines--naming-conventions))
29-
- [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/csharp-http-client/blob/master/CONTRIBUTING.md#creating-a-pull-request)).
24+
If you have questions, please send an email to [Sendgrid](mailto:[email protected]), or file a Github Issue in this repository.

0 commit comments

Comments
 (0)