Merge pull request #355 from mirkotschaeni/add-version-to-capabilities

ddavison · web-flow · commit ef0ea51411ec · 2017-01-04T12:27:50.000-05:00
add “version” property to capabilities object in generate_config
diff --git a/NodeChrome/generate_config b/NodeChrome/generate_config
@@ -1,9 +1,12 @@
 #!/bin/bash
 
+CHROME_VERSION=$( sudo dpkg -s google-chrome-stable | grep Version | cut -d " " -f 2 | cut -d "-" -f 1 )
+
 echo "
 {
   \"capabilities\": [
     {
+      \"version\": \"$CHROME_VERSION\",
       \"browserName\": \"chrome\",
       \"maxInstances\": $NODE_MAX_INSTANCES,
       \"seleniumProtocol\": \"WebDriver\"
diff --git a/NodeFirefox/generate_config b/NodeFirefox/generate_config
@@ -1,9 +1,12 @@
 #!/bin/bash
 
+FIREFOX_VERSION=$( firefox -version | cut -d " " -f 3 )
+
 echo "
 {
   \"capabilities\": [
     {
+      \"version\": \"$FIREFOX_VERSION\",
       \"browserName\": \"firefox\",
       \"maxInstances\": $NODE_MAX_INSTANCES,
       \"seleniumProtocol\": \"WebDriver\"

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,12 @@`
`1`	`1`	`#!/bin/bash`
`2`	`2`
	`3`	`+CHROME_VERSION=$( sudo dpkg -s google-chrome-stable \| grep Version \| cut -d " " -f 2 \| cut -d "-" -f 1 )`
	`4`	`+`
`3`	`5`	`echo "`
`4`	`6`	`{`
`5`	`7`	`\"capabilities\": [`
`6`	`8`	`{`
	`9`	`+ \"version\": \"$CHROME_VERSION\",`
`7`	`10`	`\"browserName\": \"chrome\",`
`8`	`11`	`\"maxInstances\": $NODE_MAX_INSTANCES,`
`9`	`12`	`\"seleniumProtocol\": \"WebDriver\"`
Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,12 @@`
`1`	`1`	`#!/bin/bash`
`2`	`2`
	`3`	`+FIREFOX_VERSION=$( firefox -version \| cut -d " " -f 3 )`
	`4`	`+`
`3`	`5`	`echo "`
`4`	`6`	`{`
`5`	`7`	`\"capabilities\": [`
`6`	`8`	`{`
	`9`	`+ \"version\": \"$FIREFOX_VERSION\",`
`7`	`10`	`\"browserName\": \"firefox\",`
`8`	`11`	`\"maxInstances\": $NODE_MAX_INSTANCES,`
`9`	`12`	`\"seleniumProtocol\": \"WebDriver\"`