Remove redundant macros in response/result.rs #1107
Merged
+161
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
8 tasks
wprzytula
previously approved these changes
Oct 26, 2024
Collaborator
wprzytula
left a comment
wprzytula
left a comment
There was a problem hiding this comment.
Thank you very much for noticing that it's not necessary to use macros here!
This macro is unnecessary, function is enough here. For ease of future development, lets get rid of such macros.
…ction This macro is unnecessary, function is enough here. For ease of future development, lets get rid of such macros.
Lorak-mmk
force-pushed
the
remove_redundant_macros
branch
from
57bc516 to
b1b3b81
Compare
wprzytula
approved these changes
Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_deser_typeandgenerate_deser_col_specsare not necessary: generic function is enough.To ease future development this PR removes those macros.
Pre-review checklist
I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.