Skip to content

Commit 49988b9

Browse files
committed
trivial fixing according to reviews
1 parent 5d7db16 commit 49988b9

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

coordinator/internal/logic/libzkp/lib.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ func SetDynamicFeature(feats string) {
149149
}
150150

151151
// UnivTaskCompatibilityFix calls the universal task compatibility fix function
152-
func UnivTaskCompatibilityFix(taskJSON string) (string, error) {
152+
func UniversalTaskCompatibilityFix(taskJSON string) (string, error) {
153153
cTaskJSON := goToCString(taskJSON)
154154
defer freeCString(cTaskJSON)
155155

coordinator/internal/logic/provertask/prover_task.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ func isCompatibilityFixingVersion(ver string) bool {
210210

211211
func fixCompatibility(schema *coordinatorType.GetTaskSchema) error {
212212

213-
fixedTask, err := libzkp.UnivTaskCompatibilityFix(schema.TaskData)
213+
fixedTask, err := libzkp.UniversalTaskCompatibilityFix(schema.TaskData)
214214
if err != nil {
215215
return err
216216
}

crates/libzkp/src/lib.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ pub fn checkout_chunk_task(
5050
pub fn univ_task_compatibility_fix(task_json: &str) -> eyre::Result<String> {
5151
use scroll_zkvm_types::proof::VmInternalStarkProof;
5252

53-
let u_task: tasks::ProvingTask = serde_json::from_str(task_json)?;
54-
let aggregated_proofs: Vec<VmInternalStarkProof> = u_task
53+
let task: tasks::ProvingTask = serde_json::from_str(task_json)?;
54+
let aggregated_proofs: Vec<VmInternalStarkProof> = task
5555
.aggregated_proofs
5656
.into_iter()
5757
.map(|proof| VmInternalStarkProof {
@@ -77,11 +77,11 @@ pub fn univ_task_compatibility_fix(task_json: &str) -> eyre::Result<String> {
7777
}
7878

7979
let compatible_u_task = CompatibleProvingTask {
80-
serialized_witness: u_task.serialized_witness,
80+
serialized_witness: task.serialized_witness,
8181
aggregated_proofs,
82-
fork_name: u_task.fork_name,
83-
vk: u_task.vk,
84-
identifier: u_task.identifier,
82+
fork_name: task.fork_name,
83+
vk: task.vk,
84+
identifier: task.identifier,
8585
};
8686

8787
Ok(serde_json::to_string(&compatible_u_task)?)

0 commit comments

Comments
 (0)