From 25ebc64421b09ac3c5a3b1bc91719ffd233f66a5 Mon Sep 17 00:00:00 2001 From: melle Date: Tue, 26 Oct 2021 15:45:18 +0200 Subject: [PATCH 1/5] Update index.js Fixses https://script.atlassian.net/browse/RAPP-571 --- src/app/index.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/app/index.js b/src/app/index.js index 2b8051d..0bd2f21 100644 --- a/src/app/index.js +++ b/src/app/index.js @@ -43,7 +43,13 @@ export class AppStarter { this._authService .getLoggedInUser() - .catch() + .catch( (/** @type {import(axios).AxiosError} */ error) => { + if (error.response.status == 401) { + console.log(error.response.message) + window.location.href = "/login"; + } + } + ) .finally(() => { this._eventService.app = new Vue({ el: '#app', From b06ce93078703b355283f190cc06faac96d08b52 Mon Sep 17 00:00:00 2001 From: melle Date: Tue, 26 Oct 2021 15:48:08 +0200 Subject: [PATCH 2/5] Update index.js --- src/app/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/app/index.js b/src/app/index.js index 0bd2f21..d04952b 100644 --- a/src/app/index.js +++ b/src/app/index.js @@ -46,6 +46,7 @@ export class AppStarter { .catch( (/** @type {import(axios).AxiosError} */ error) => { if (error.response.status == 401) { console.log(error.response.message) + // TODO propagate the response message window.location.href = "/login"; } } From 4a1d7f0b357ef60c71041ea824379caf58703602 Mon Sep 17 00:00:00 2001 From: melle Date: Thu, 28 Oct 2021 12:27:01 +0200 Subject: [PATCH 3/5] Update index.js --- src/app/index.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/app/index.js b/src/app/index.js index d04952b..e723492 100644 --- a/src/app/index.js +++ b/src/app/index.js @@ -44,9 +44,8 @@ export class AppStarter { this._authService .getLoggedInUser() .catch( (/** @type {import(axios).AxiosError} */ error) => { - if (error.response.status == 401) { - console.log(error.response.message) - // TODO propagate the response message + if (error.response.status === 401) { + // TODO propagate the error.response.message for better user feedback window.location.href = "/login"; } } From 7ab2a5fd1b35d9bbbaa443019b7c0243de17a34b Mon Sep 17 00:00:00 2001 From: melle Date: Fri, 29 Oct 2021 15:21:37 +0200 Subject: [PATCH 4/5] Resolved --- src/app/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/index.js b/src/app/index.js index e723492..3512e9c 100644 --- a/src/app/index.js +++ b/src/app/index.js @@ -46,7 +46,7 @@ export class AppStarter { .catch( (/** @type {import(axios).AxiosError} */ error) => { if (error.response.status === 401) { // TODO propagate the error.response.message for better user feedback - window.location.href = "/login"; + window.location.href = this._authService._apiLoginRoute; } } ) From fca88d29706db998f1027b125e345f0d801b0bb6 Mon Sep 17 00:00:00 2001 From: melle Date: Fri, 29 Oct 2021 15:24:42 +0200 Subject: [PATCH 5/5] reslove suggestions from user --- src/app/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/app/index.js b/src/app/index.js index 3512e9c..73f9c5e 100644 --- a/src/app/index.js +++ b/src/app/index.js @@ -21,6 +21,8 @@ export class AppStarter { this._eventService = eventService; this._authService = authService; this._staticDataService = staticDataService; + this._LoginRoute= "/inloggen"; + } /** @@ -46,7 +48,7 @@ export class AppStarter { .catch( (/** @type {import(axios).AxiosError} */ error) => { if (error.response.status === 401) { // TODO propagate the error.response.message for better user feedback - window.location.href = this._authService._apiLoginRoute; + window.location.href = this._LoginRoute; } } )