Enable linter and fix some warnings

Author: jozic

pom.xml

@@ -212,6 +212,10 @@ under the License.
                     <version>3.13.0</version>
                     <configuration>
                         <release>11</release>
+                        <compilerArgs>
+                            <arg>-Xlint:all</arg>
+                            <arg>-Xlint:-processing</arg>
+                        </compilerArgs>
                     </configuration>
                 </plugin>
 
@@ -273,9 +277,9 @@ under the License.
                         <subpackages>org.scoverage.plugin</subpackages>
                         <links>
                             <link>https://docs.oracle.com/en/java/javase/11/docs/api/</link>
-                            <link>https://maven.apache.org/ref/${maven.version}/apidocs/</link>
                             <link>https://maven.apache.org/shared-archives/maven-reporting-api-${maven-reporting-api.version}/apidocs/</link>
                             <link>https://maven.apache.org/doxia/components/doxia-archives/doxia-${doxia.version}/apidocs/</link>
+                            <link>https://maven.apache.org/ref/${maven.version}/apidocs/</link>
                         </links>
                         <notimestamp>true</notimestamp>
                     </configuration>

src/main/java/org/scoverage/plugin/SCoveragePreCompileMojo.java

@@ -24,6 +24,7 @@
 import java.io.OutputStreamWriter;
 import java.util.*;
 import java.util.stream.Collectors;
+import javax.inject.Inject;
 
 import org.apache.maven.artifact.Artifact;
 import org.apache.maven.artifact.factory.ArtifactFactory;
@@ -37,7 +38,6 @@
 import org.apache.maven.model.Dependency;
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
-import org.apache.maven.plugins.annotations.Component;
 import org.apache.maven.plugins.annotations.LifecyclePhase;
 import org.apache.maven.plugins.annotations.Mojo;
 import org.apache.maven.plugins.annotations.Parameter;
@@ -171,13 +171,13 @@ public class SCoveragePreCompileMojo
     /**
      * Artifact factory used to look up artifacts in the remote repository.
      */
-    @Component
+    @Inject
     private ArtifactFactory factory;
 
     /**
      * Artifact resolver used to resolve artifacts.
      */
-    @Component
+    @Inject
     private ArtifactResolver resolver;
 
     /**

src/main/java/org/scoverage/plugin/SCoverageReportMojo.java

@@ -388,7 +388,7 @@ public void execute()
 
         try
         {
-            RenderingContext context = new RenderingContext( outputDirectory, getOutputName() + ".html" );
+            RenderingContext context = new RenderingContext( outputDirectory, getOutputName() + ".html", null );
             SiteRendererSink sink = new SiteRendererSink( context );
             Locale locale = Locale.getDefault();
             generate( sink, locale );

src/main/java/org/scoverage/plugin/ScalaVersion.java

@@ -80,7 +80,7 @@ public ScalaVersion(String s) {
         // compute compatible
         compatible =
                 modifier != null ? full : // non-stable versions are not compatible with anything else
-                        isScala2() ? major + "." + minor : // Scala 2.X.Y is compatible with any Scala 2.X.Z
+                        major == 2 ? major + "." + minor : // Scala 2.X.Y is compatible with any Scala 2.X.Z
                                 major + ""; // Scala 3.X is compatible with any Scala 3.Y
     }