Skip to content

Commit 32c24fe

Browse files
authored
Merge pull request #254 from scoverage/scala-2-13-0-RC1
Add Scala 2.13.0-RC1 support
2 parents 9cf6357 + f1e50bd commit 32c24fe

File tree

5 files changed

+21
-15
lines changed

5 files changed

+21
-15
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ scala:
1010
- 2.10.7
1111
- 2.11.12
1212
- 2.12.8
13-
- 2.13.0-M5
13+
- 2.13.0-RC1
1414

1515
before_cache:
1616
- find "$HOME/.sbt/" -name '*.lock' -print0 | xargs -0 rm

build.sbt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import sbtcrossproject.CrossProject
66
import sbtcrossproject.CrossType
77

88
val Org = "org.scoverage"
9-
val ScalatestVersion = "3.0.6-SNAP4"
9+
val ScalatestVersion = "3.0.8-RC2"
1010

1111
val appSettings = Seq(
1212
organization := Org,
1313
scalaVersion := "2.12.8",
14-
crossScalaVersions := Seq("2.10.7", "2.11.12", "2.12.8", "2.13.0-M5"),
14+
crossScalaVersions := Seq("2.10.7", "2.11.12", "2.12.8", "2.13.0-RC1"),
1515
fork in Test := false,
1616
publishMavenStyle := true,
1717
publishArtifact in Test := false,
@@ -43,6 +43,11 @@ val appSettings = Seq(
4343
<name>Stephen Samuel</name>
4444
<url>http://github.com/sksamuel</url>
4545
</developer>
46+
<developer>
47+
<id>gslowikowski</id>
48+
<name>Grzegorz Slowikowski</name>
49+
<url>http://github.com/gslowikowski</url>
50+
</developer>
4651
</developers>
4752
},
4853
pomIncludeRepository := {
@@ -97,7 +102,7 @@ lazy val plugin = Project("scalac-scoverage-plugin", file("scalac-scoverage-plug
97102
libraryDependencies ++= {
98103
CrossVersion.partialVersion(scalaVersion.value) match {
99104
case Some((2, scalaMajor)) if scalaMajor > 10 =>
100-
Seq("org.scala-lang.modules" %% "scala-xml" % "1.1.1")
105+
Seq("org.scala-lang.modules" %% "scala-xml" % "1.2.0")
101106
case _ =>
102107
Seq()
103108
}

scalac-scoverage-plugin/src/test/scala/scoverage/LocationTest.scala

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class LocationTest extends FreeSpec with Matchers {
1919
}
2020
"for objects" in {
2121
val compiler = ScoverageCompiler.locationCompiler
22-
compiler.compile("package com.test\nobject Bammy { def foo = 'boo } ")
22+
compiler.compile("package com.test\nobject Bammy { def foo = Symbol(\"boo\") } ")
2323
val loc = compiler.locations.result().find(_._1 == "Template").get._2
2424
loc.packageName shouldBe "com.test"
2525
loc.className shouldBe "Bammy"
@@ -30,7 +30,7 @@ class LocationTest extends FreeSpec with Matchers {
3030
}
3131
"for traits" in {
3232
val compiler = ScoverageCompiler.locationCompiler
33-
compiler.compile("package com.test\ntrait Gammy { def goo = 'hoo } ")
33+
compiler.compile("package com.test\ntrait Gammy { def goo = Symbol(\"hoo\") } ")
3434
val loc = compiler.locations.result().find(_._1 == "Template").get._2
3535
loc.packageName shouldBe "com.test"
3636
loc.className shouldBe "Gammy"
@@ -42,7 +42,7 @@ class LocationTest extends FreeSpec with Matchers {
4242
}
4343
"should correctly process methods" in {
4444
val compiler = ScoverageCompiler.locationCompiler
45-
compiler.compile("package com.methodtest \n class Hammy { def foo = 'boo } ")
45+
compiler.compile("package com.methodtest \n class Hammy { def foo = Symbol(\"boo\") } ")
4646
val loc = compiler.locations.result().find(_._2.method == "foo").get._2
4747
loc.packageName shouldBe "com.methodtest"
4848
loc.className shouldBe "Hammy"
@@ -150,7 +150,7 @@ class LocationTest extends FreeSpec with Matchers {
150150
"should use <none> method name" - {
151151
"for class constructor body" in {
152152
val compiler = ScoverageCompiler.locationCompiler
153-
compiler.compile("package com.b \n class Tammy { val name = 'sam } ")
153+
compiler.compile("package com.b \n class Tammy { val name = Symbol(\"sam\") } ")
154154
val loc = compiler.locations.result().find(_._1 == "ValDef").get._2
155155
loc.packageName shouldBe "com.b"
156156
loc.className shouldBe "Tammy"
@@ -161,7 +161,7 @@ class LocationTest extends FreeSpec with Matchers {
161161
}
162162
"for object constructor body" in {
163163
val compiler = ScoverageCompiler.locationCompiler
164-
compiler.compile("package com.b \n object Yammy { val name = 'sam } ")
164+
compiler.compile("package com.b \n object Yammy { val name = Symbol(\"sam\") } ")
165165
val loc = compiler.locations.result().find(_._1 == "ValDef").get._2
166166
loc.packageName shouldBe "com.b"
167167
loc.className shouldBe "Yammy"
@@ -172,7 +172,7 @@ class LocationTest extends FreeSpec with Matchers {
172172
}
173173
"for trait constructor body" in {
174174
val compiler = ScoverageCompiler.locationCompiler
175-
compiler.compile("package com.b \n trait Wammy { val name = 'sam } ")
175+
compiler.compile("package com.b \n trait Wammy { val name = Symbol(\"sam\") } ")
176176
val loc = compiler.locations.result().find(_._1 == "ValDef").get._2
177177
loc.packageName shouldBe "com.b"
178178
loc.className shouldBe "Wammy"
@@ -209,7 +209,7 @@ class LocationTest extends FreeSpec with Matchers {
209209
}
210210
"doubly nested classes should report correct fullClassName" in {
211211
val compiler = ScoverageCompiler.locationCompiler
212-
compiler.compile("package com.a \n object Foo { object Boo { object Moo { val name = 'sam } } }")
212+
compiler.compile("package com.a \n object Foo { object Boo { object Moo { val name = Symbol(\"sam\") } } }")
213213
val loc = compiler.locations.result().find(_._1 == "ValDef").get._2
214214
loc.packageName shouldBe "com.a"
215215
loc.className shouldBe "Moo"

scalac-scoverage-plugin/src/test/scala/scoverage/PluginCoverageTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class PluginCoverageTest
1414
compiler.compileCodeSnippet( """ object DefaultArgumentsObject {
1515
| val defaultName = "world"
1616
| def makeGreeting(name: String = defaultName): String = {
17-
| s"Hello, $name"
17+
| "Hello, " + name
1818
| }
1919
|} """.stripMargin)
2020
assert(!compiler.reporter.hasErrors)

scalac-scoverage-plugin/src/test/scala/scoverage/ScoverageCompiler.scala

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ object ScoverageCompiler {
2121

2222
def settings: Settings = {
2323
val s = new scala.tools.nsc.Settings
24-
s.Xprint.value = List("all")
24+
s.Xprint.value = List("all", "_")
2525
s.deprecation.value = true
2626
s.Yrangepos.value = true
2727
s.Yposdebug.value = true
@@ -99,9 +99,10 @@ class ScoverageCompiler(settings: scala.tools.nsc.Settings, reporter: scala.tool
9999
compileSourceFiles(urls.map(_.getFile).map(new File(_)): _*)
100100
}
101101

102-
def assertNoErrors() = assert(!reporter.hasErrors)
102+
def assertNoErrors() = assert(!reporter.hasErrors, "There are compilation errors")
103103

104-
def assertNoCoverage() = assert(!testStore.sources.mkString(" ").contains(s"scoverage.Invoker.invoked"))
104+
def assertNoCoverage() = assert(!testStore.sources.mkString(" ").contains(s"scoverage.Invoker.invoked"),
105+
"There are scoverage.Invoker.invoked instructions added to the code")
105106

106107
def assertNMeasuredStatements(n: Int): Unit = {
107108
for (k <- 1 to n) {

0 commit comments

Comments
 (0)