Skip to content

MMC - fit_diag can potentially loop forever #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shalan12 opened this issue Dec 11, 2017 · 2 comments
Closed

MMC - fit_diag can potentially loop forever #79

shalan12 opened this issue Dec 11, 2017 · 2 comments
Labels
bug
Milestone
v0.4.0

Comments

@shalan12
Copy link
Contributor

For the condition in the while loop in MMC - fit_diag
while error > self.convergence_threshold:

I think the number of iterations should also be checked here. I've had runs where it keeps running and getting the same value for conv. It doesn't respect max_iter, and doesn't terminate.
@perimosocordiae
Copy link
Contributor

I agree, the _fit_diag method should respect max_iter. Feel free to open a PR if you'd like to fix it!

@perimosocordiae perimosocordiae added this to the v0.4.0 milestone Dec 11, 2017
@perimosocordiae
Copy link
Contributor

Fixed by gh-80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
2 participants
@perimosocordiae @shalan12