Skip to content

Error with modshogun #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wdevazelhes opened this issue Apr 18, 2019 · 3 comments · Fixed by #216
Closed

Error with modshogun #192

wdevazelhes opened this issue Apr 18, 2019 · 3 comments · Fixed by #216
Milestone

Comments

@wdevazelhes
Copy link
Member

I think there is a problem when using shogun:
First after I installed shogun (the last version, I tried to install with conda forge and also pip), I cannot import modshogun (it throws a package not found error), but instead I can import shogun. Maybe I messed up somewhere in the install process or maybe the newest version have a different name or sth..

Even if I change the code with import shogun instead of import modshogun, there is another error when doing:

from metric_learn import LMNN
from sklearn.datasets import make_blobs
X, y = make_blobs(n_features=2)
X.shape
lmnn = LMNN()
lmnn.fit(X,y)

And it returns the following error:

NotImplementedError: Wrong number or type of arguments for overloaded function 'new_MulticlassLabels'.
  Possible C/C++ prototypes are:
    shogun::CMulticlassLabels::CMulticlassLabels()
    shogun::CMulticlassLabels::CMulticlassLabels(int32_t)
    shogun::CMulticlassLabels::CMulticlassLabels(shogun::SGVector< float64_t >)
    shogun::CMulticlassLabels::CMulticlassLabels(shogun::CFile *)
    shogun::CMulticlassLabels::CMulticlassLabels(shogun::CBinaryLabels *)
@bellet
Copy link
Member

bellet commented Apr 18, 2019

It is probably a version issue?

@perimosocordiae
Copy link
Contributor

When I set up shogun initially, I built it from source and enabled the "python_modular" interface.

It seems like things have changed since then: shogun-toolbox/shogun#3898

We should update our usage of Shogun, or remove it entirely if it's going to be a pain.

@bellet
Copy link
Member

bellet commented Apr 23, 2019

Also it does not seem like Shogun_LMNN can do dimensionality reduction, which is at odds with the objective of #193. So maybe it is easier to remove it? We could try to work on an optimized version of LMNN later

@wdevazelhes wdevazelhes added this to the v0.5.0 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants