feat: add config_settings as metadata plugin argument

Author: Ben Rowland

src/scikit_build_core/build/wheel.py

@@ -73,7 +73,7 @@ def _build_wheel_impl(
 
     settings_reader.validate_may_exit()
 
-    metadata = get_standard_metadata(pyproject, settings)
+    metadata = get_standard_metadata(pyproject, settings, config_settings)
 
     if metadata.version is None:
         msg = "project.version is not statically specified, must be present currently"

src/scikit_build_core/builder/wheel_tag.py

@@ -37,7 +37,7 @@ def compute_best(
         pyvers = [interp]
 
         if sys.platform.startswith("win") and archs:
-            plats = (x.replace("-", "_") for x in archs)
+            plats = [x.replace("-", "_") for x in archs]
         elif sys.platform.startswith("darwin"):
             pairs: Iterable[tuple[str | None, bool]]
             if expand_macos and archs == ["universal2"]:

src/scikit_build_core/metadata/fancy_pypi_readme.py

@@ -10,7 +10,8 @@ def __dir__() -> list[str]:
 
 
 def dynamic_metadata(
-    pyproject_dict: dict[str, Any]
+    pyproject_dict: dict[str, Any],
+    _config_settings: dict[str, list[str] | str] | None = None,
 ) -> dict[str, str | dict[str, str | None]]:
     from hatch_fancy_pypi_readme._builder import build_text
     from hatch_fancy_pypi_readme._config import load_and_validate_config

src/scikit_build_core/metadata/setuptools_scm.py

@@ -8,7 +8,8 @@ def __dir__() -> list[str]:
 
 
 def dynamic_metadata(
-    pyproject_dict: dict[str, object]  # noqa: ARG001
+    pyproject_dict: dict[str, object],  # noqa: ARG001
+    _config_settings: dict[str, list[str] | str] | None = None,
 ) -> dict[str, str | dict[str, str | None]]:
     # this is a classic implementation, waiting for the release of
     # vcs-versioning and an improved public interface

src/scikit_build_core/settings/metadata.py

@@ -14,13 +14,19 @@ def __dir__() -> list[str]:
     return __all__
 
 
-def _load(mod_name: str, pyproject_dict: dict[str, Any]) -> dict[str, Any]:
-    return importlib.import_module(mod_name).dynamic_metadata(pyproject_dict)  # type: ignore[no-any-return]
+def _load(
+    mod_name: str,
+    pyproject_dict: dict[str, Any],
+    config_settings: dict[str, list[str] | str] | None = None,
+) -> dict[str, Any]:
+    return importlib.import_module(mod_name).dynamic_metadata(pyproject_dict, config_settings)  # type: ignore[no-any-return]
 
 
 # If pyproject-metadata eventually supports updates, this can be simplified
 def get_standard_metadata(
-    pyproject_dict: dict[str, Any], settings: ScikitBuildSettings
+    pyproject_dict: dict[str, Any],
+    settings: ScikitBuildSettings,
+    config_settings: dict[str, list[str] | str] | None = None,
 ) -> StandardMetadata:
     # Handle any dynamic metadata
     for field in settings.metadata:
@@ -29,7 +35,9 @@ def get_standard_metadata(
             raise KeyError(msg)
 
     plugins = set(settings.metadata.values())
-    cached_plugins = {key: _load(key, pyproject_dict) for key in plugins}
+    cached_plugins = {
+        key: _load(key, pyproject_dict, config_settings) for key in plugins
+    }
 
     for field, mod_name in settings.metadata.items():
         if field not in cached_plugins[mod_name]:

tests/test_dynamic_metadata.py

@@ -25,13 +25,15 @@
 # it turns out to be easier to create EntryPoint objects pointing to real
 # functions than to mock them.
 def ep_version(
-    _pyproject_dict: dict[str, Any]
+    _pyproject_dict: dict[str, Any],
+    _config_settings: dict[str, list[str] | str] | None = None,
 ) -> dict[str, str | dict[str, str | None]]:
     return {"version": "0.0.2"}
 
 
 def ep_readme(
-    _pyproject_dict: dict[str, Any]
+    _pyproject_dict: dict[str, Any],
+    _config_settings: dict[str, list[str] | str] | None = None,
 ) -> dict[str, str | dict[str, str | None]]:
     return {
         "readme": {
@@ -42,12 +44,16 @@ def ep_readme(
 
 
 def ep_license(
-    _pyproject_dict: dict[str, Any]
+    _pyproject_dict: dict[str, Any],
+    _config_settings: dict[str, list[str] | str] | None = None,
 ) -> dict[str, str | dict[str, str | None]]:
     return {"license": {"text": "MIT License"}}
 
 
-def ep_dual(_pyproject_dict: dict[str, Any]) -> dict[str, str | dict[str, str | None]]:
+def ep_dual(
+    _pyproject_dict: dict[str, Any],
+    _config_settings: dict[str, list[str] | str] | None = None,
+) -> dict[str, str | dict[str, str | None]]:
     return {
         "version": "0.3",
         "license": {"text": "BSD License"},