-
Notifications
You must be signed in to change notification settings - Fork 8
😎 Port site to mystmd (work in progress) #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
😎 Port site to mystmd (work in progress) #81
Conversation
|
Neat, thanks Brian! I notice:
Nice work, thanks! |
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this. I have some preliminary comments, none of which is content related and don't have the preview link.
So I would think we should commit the CI config to main independently, so the preview is being picked up for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just leave this file alone an append any new ignores to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarrodmillman and @stefanv can comment if we also use this refactor for restructuring/restarting the team? This list was made at the second summit and since then people seem to have less time for this team while others stepped up.
| id: ee007168-b9a5-4dba-8823-1639a4aeb956 | ||
| abbreviations: | ||
| CSS: Cascading Style Sheet | ||
| toc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all good now as the toc is not too long, but overall I would advocate for keeping the toc and the myst config separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you thinking add a separate _toc.yml like described here: https://mystmd.org/guide/table-of-contents#toc-format-legacy (as deprecated)?
Or is there a newer way to include a separate chunk of yaml as sub-config into the primary myst.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is there a newer way to include a separate chunk of yaml as sub-config into the primary
myst.yml?
Huh, pretty sure this is possible now, but I can't find the PR or the docs entry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Give a thumbs up on that PR, if you get a chance, please!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs already exist here: https://jupyterbook.org/stable/authoring/table-of-contents/#external-toc-files-using-extends
(and out in the wild, I use it here: https://github.com/Caltech-IPAC/irsa-tutorials/blob/main/myst.yml#L22)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thanks Brigitta and Stéfan!
I had only looked at the TOC page in the myst guide and there's no mention of it there. The jupyter-book guide wasn't even on my radar, but now I'll know to search there too! I also found a handful of other spots in the myst guide that mention extends but which are not found in the jupyter-book guide:
- https://mystmd.org/guide/document-parts#share-the-same-part-across-multiple-sites
- https://mystmd.org/guide/frontmatter#composing-myst-yml
- https://mystmd.org/guide/authorship#re-use-author-information-across-repositories-and-projects
What is the relationship between the two guides?
Feels like we're missing a documentation page describing the myst.yml file itself. Maybe "Configuration" under the "Reference" section? That could
- Detail exactly what keys are expected/accepted there, which ones are optional vs required, summarize what they mean, then link out to those more specialized pages dedicated to authors, toc, frontmatter, parts, ...etc.
- Explain the difference between
projectandsite. - 👉 Describe the extension mechanism.
- Mention the
--configCLI option. - ...
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no one else has brought this up / made a ticket, I could mention in the #documentation thread on Discord; but I'm probably not the best person to execute on it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had only looked at the TOC page in the myst guide and there's no mention of it there. The jupyter-book guide wasn't even on my radar, but now I'll know to search there too! I also found a handful of other spots in the myst guide that mention extends but which are not found in the jupyter-book guide:
This is all quickly evolving, it got the extends suggestion on discord. Then I remembered to point out to the review of the jupyerbook docs, but apparently it hasn't yet made its way to the myst docs.
There are a bunch of open docs PRs for mystmd (one about extends others about better structuring to help discoverability of config options, etc), hopefully they will get merged and then we can do a better sweep for still missing things.
I fully agree that the guides and docs are not consistent, and I personally find it still very difficult to find things in the mystmd docs where I assume they should be.
So, overall, I think you should open issues for any of the inconsistencies you run into, at least to put it on the radar of people.
Anyway, back to this review comment, this is one of those that doesn't need to be addressed in this PR. Get this all run is more important, we can then tweak the content in a follow-up, if necessary.
Implement site as a mystmd book instead of as a Hugo site.
Closes #77