Skip to content

Consider reverting to Scala 2 implementation for @volatile lazy fields #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
allanrenucci opened this issue Nov 15, 2018 · 2 comments
Closed

Consider reverting to Scala 2 implementation for @volatile lazy fields #5448

allanrenucci opened this issue Nov 15, 2018 · 2 comments
Labels
area:benchmarks area:transform itype:question

Comments

@allanrenucci
Copy link
Contributor

allanrenucci commented Nov 15, 2018 •
edited
Loading

We have concerns about the size of the generated code, the performance characteristics and the correctness of the new implementation.

Should we revert to the Scala 2 implementation for thread safe lazy fields? One can always revive SIP-20 in the future.
@allanrenucci
Copy link
Contributor Author

I'll do an implementation of Scala 2 lazy vals for Dotty and try to benchmark them against our current lazy vals

@smarter
Copy link
Member

smarter commented Feb 28, 2020

Closing in favor of #7140 which is also on the theme of changing lazy val implementation.

@smarter smarter closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:benchmarks area:transform itype:question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smarter @allanrenucci