Skip to content

Commit dbb1e6c

Browse files
authored
Fix the CI not running on merge commits (#16668)
2 parents 2833b36 + cb1cf61 commit dbb1e6c

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

.github/workflows/ci.yaml

+12-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,18 @@ name: Dotty
22

33
on:
44
push:
5-
tags:
6-
- '**'
5+
## Be careful if you add or remove something here! Quoting from
6+
## <https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore>:
7+
##
8+
## > If you define only tags/tags-ignore or only branches/branches-ignore, the
9+
## > workflow won't run for events affecting the undefined Git ref. If you
10+
## > define neither tags/tags-ignore or branches/branches-ignore, the workflow
11+
## > will run for events affecting either branches or tags.
12+
##
13+
## We want the CI to run on both branches and tags, so we should either have:
14+
## - both (tags or tags-ignore) and (branches or branches-ignore),
15+
## - or neither of them.
16+
## But it's important to not have only one or the other.
717
pull_request:
818
schedule:
919
- cron: '0 3 * * *' # Every day at 3 AM

0 commit comments

Comments
 (0)