Add error reporting to TASTy reflect

Author: nicolasstucki

compiler/src/dotty/tools/dotc/tastyreflect/KernelImpl.scala

@@ -29,6 +29,16 @@ class KernelImpl(val rootContext: core.Contexts.Context, val rootPosition: util.
 
   def Context_source(self: Context): java.nio.file.Path = self.compilationUnit.source.file.jpath
 
+  //
+  // REPORTING
+  //
+
+  def error(msg: => String, pos: Position)(implicit ctx: Context): Unit =
+    ctx.error(msg, pos)
+
+  def warning(msg: => String, pos: Position)(implicit ctx: Context): Unit =
+    ctx.warning(msg, pos)
+
   //
   // Settings
   //

compiler/src/dotty/tools/dotc/typer/Inliner.scala

@@ -441,6 +441,7 @@ class Inliner(call: tpd.Tree, rhsToInline: tpd.Tree)(implicit ctx: Context) {
         case tree: Ident =>
           paramProxy.get(tree.tpe) match {
             case Some(t) if tree.isTerm && t.isSingleton =>
+              // FIXME wrong span, this is the span inside the inline method
               singleton(t.dealias).withSpan(tree.span)
             case Some(t) if tree.isType =>
               TypeTree(t).withSpan(tree.span)

library/src/scala/tasty/Reflection.scala

@@ -14,6 +14,7 @@ abstract class Reflection
     with PatternOps
     with PositionOps
     with Printers
+    with ReportingOps
     with RootPosition
     with SettingsOps
     with SignatureOps

library/src/scala/tasty/reflect/Kernel.scala

@@ -136,6 +136,16 @@ trait Kernel {
   /** Returns the source file being compiled. The path is relative to the current working directory. */
   def Context_source(self: Context): java.nio.file.Path
 
+  //
+  // REPORTING
+  //
+
+  /** Report a compilation error with the given message at the given position */
+  def error(msg: => String, pos: Position)(implicit ctx: Context): Unit
+
+  /** Report a compilation warning with the given message at the given position */
+  def warning(msg: => String, pos: Position)(implicit ctx: Context): Unit
+
   //
   // Settings
   //

library/src/scala/tasty/reflect/ReportingOps.scala

@@ -0,0 +1,11 @@
+package scala.tasty.reflect
+
+trait ReportingOps extends Core {
+
+  def error(msg: => String, pos: Position)(implicit ctx: Context): Unit =
+    kernel.error(msg, pos)
+
+  def warning(msg: => String, pos: Position)(implicit ctx: Context): Unit =
+    kernel.warning(msg, pos)
+
+}

tests/neg/tasty-macro-error.check

@@ -0,0 +1,9 @@
+[108..109] in quoted_2.scala
+here is the the argument x
+[206..207] in quoted_2.scala
+here is the the argument "abc"
+[108..109] in quoted_2.scala
+here is the the argument x
+[128..133] in quoted_2.scala
+here is the the argument "abc"
+// TODO

tests/neg/tasty-macro-error/quoted_1.scala

@@ -0,0 +1,25 @@
+import scala.quoted._
+
+import scala.tasty._
+
+object Macros {
+
+  inline def fun(x: Any): Unit = ${ impl('x) }
+
+  inline def fun2(x: =>Any): Unit = ${ impl('x) }
+
+  inline def fun3[T]: Unit = ${ impl2('[T]) }
+
+  def impl(x: Expr[Any])(implicit reflect: Reflection): Expr[Unit] = {
+    import reflect._
+    error("here is the the argument " + x.unseal.showCode, x.unseal.underlyingArgument.pos)
+    '{}
+  }
+
+  def impl2[T](x: quoted.Type[T])(implicit reflect: Reflection): Expr[Unit] = {
+    import reflect._
+    error("here is the the argument " + x.unseal.showCode, x.unseal.pos)
+    '{}
+  }
+
+}

tests/neg/tasty-macro-error/quoted_2.scala

@@ -0,0 +1,19 @@
+
+import Macros._
+
+object Test {
+  def main(args: Array[String]): Unit = {
+    def x: String = "abc"
+    fun(x) // error
+    fun("abc") // error
+
+    fun2(x) // error
+    fun2("abc") // error
+
+    type T
+    fun3[T] // error
+    fun3[String] // error
+    fun3["abc"] // error
+  }
+
+}