Handle context function arguments in overloading resolution (#16511)

Fixes #16506

We now handle the cases where an argument of an overloaded method is a
context closure. The closure must be given implicitly. It cannot be
inferred since at the time where the argument is typed, there is no
expected expected type to expand it to a context closure.

Author: odersky

compiler/src/dotty/tools/dotc/ast/Desugar.scala

@@ -1464,7 +1464,10 @@ object desugar {
     val param = makeSyntheticParameter(
       tpt =
         if params.exists(_.tpt.isEmpty) then TypeTree()
-        else Tuple(params.map(_.tpt)))
+        else Tuple(params.map(_.tpt)),
+      flags =
+        if params.nonEmpty && params.head.mods.is(Given) then SyntheticTermParam | Given
+        else SyntheticTermParam)
     def selector(n: Int) =
       if (isGenericTuple) Apply(Select(refOfDef(param), nme.apply), Literal(Constant(n)))
       else Select(refOfDef(param), nme.selectorName(n))

compiler/src/dotty/tools/dotc/typer/Applications.scala

@@ -1923,7 +1923,9 @@ trait Applications extends Compatibility {
     /** The shape of given tree as a type; cannot handle named arguments. */
     def typeShape(tree: untpd.Tree): Type = tree match {
       case untpd.Function(args, body) =>
-        defn.FunctionOf(args map Function.const(defn.AnyType), typeShape(body))
+        defn.FunctionOf(
+          args.map(Function.const(defn.AnyType)), typeShape(body),
+          isContextual = untpd.isContextualClosure(tree))
       case Match(EmptyTree, _) =>
         defn.PartialFunctionClass.typeRef.appliedTo(defn.AnyType :: defn.NothingType :: Nil)
       case _ =>
@@ -2232,7 +2234,7 @@ trait Applications extends Compatibility {
               false
           val commonFormal =
             if (isPartial) defn.PartialFunctionOf(commonParamTypes.head, WildcardType)
-            else defn.FunctionOf(commonParamTypes, WildcardType)
+            else defn.FunctionOf(commonParamTypes, WildcardType, isContextual = untpd.isContextualClosure(arg))
           overload.println(i"pretype arg $arg with expected type $commonFormal")
           if (commonParamTypes.forall(isFullyDefined(_, ForceDegree.flipBottom)))
             withMode(Mode.ImplicitsEnabled) {

tests/pos/i16506.scala

@@ -0,0 +1,14 @@
+import scala.annotation.targetName
+
+trait Ctx
+
+def foo(f: Ctx => Int) = ???
+
+@targetName("fooContextual")
+def foo(f: Ctx ?=> Int) = ???
+
+def bar1 = foo(ctx => 123)
+def bar2 = foo((ctx: Ctx) => 123)
+def bar3 = foo(ctx ?=> 123)
+def bar4 = foo((ctx: Ctx) ?=> 123)
+// def bar5 = foo(123)   does not work