Simplify CompilerInterface abstraction mixin

Author: nicolasstucki

compiler/src/dotty/tools/dotc/quoted/Matcher.scala

@@ -4,7 +4,6 @@ import scala.annotation.internal.sharable
 import scala.annotation.{Annotation, compileTimeOnly}
 
 import scala.quoted._
-import scala.internal.tasty.CompilerInterface.quoteContextWithCompilerInterface
 
 /** Matches a quoted tree against a quoted pattern tree.
  *  A quoted pattern tree may have type and term holes in addition to normal terms.
@@ -98,7 +97,7 @@ import scala.internal.tasty.CompilerInterface.quoteContextWithCompilerInterface
  */
 object Matcher {
 
-  abstract class QuoteMatcher[QCtx <: QuoteContext { val reflect: scala.internal.tasty.CompilerInterface } & Singleton](val qctx: QCtx) {
+  abstract class QuoteMatcher[QCtx <: QuoteContext & scala.internal.quoted.CompilerInterface & Singleton](val qctx: QCtx) {
 
     // TODO improve performance
 

compiler/src/dotty/tools/dotc/quoted/QuoteContextImpl.scala

@@ -45,9 +45,9 @@ object QuoteContextImpl {
 
 }
 
-class QuoteContextImpl private (ctx: Context) extends QuoteContext:
+class QuoteContextImpl private (ctx: Context) extends QuoteContext, scala.internal.quoted.CompilerInterface:
 
-  object reflect extends scala.tasty.Reflection, scala.internal.tasty.CompilerInterface:
+  object reflect extends scala.tasty.Reflection:
 
     def rootContext: Context = ctx
 
@@ -2615,70 +2615,72 @@ class QuoteContextImpl private (ctx: Context) extends QuoteContext:
     private def withDefaultPos[T <: Tree](fn: Context ?=> T): T =
       fn(using ctx.withSource(Position.ofMacroExpansion.source)).withSpan(Position.ofMacroExpansion.span)
 
-    def unpickleTerm(pickledQuote: PickledQuote): Term =
-      PickledQuotes.unpickleTerm(pickledQuote)
-
-    def unpickleTypeTree(pickledQuote: PickledQuote): TypeTree =
-      PickledQuotes.unpickleTypeTree(pickledQuote)
+  end reflect
 
-    def termMatch(scrutinee: Term, pattern: Term): Option[Tuple] =
-      treeMatch(scrutinee, pattern)
+  def unpickleTerm(pickledQuote: PickledQuote): reflect.Term =
+    PickledQuotes.unpickleTerm(pickledQuote)(using reflect.rootContext)
 
-    def typeTreeMatch(scrutinee: TypeTree, pattern: TypeTree): Option[Tuple] =
-      treeMatch(scrutinee, pattern)
+  def unpickleTypeTree(pickledQuote: PickledQuote): reflect.TypeTree =
+    PickledQuotes.unpickleTypeTree(pickledQuote)(using reflect.rootContext)
 
-    private def treeMatch(scrutinee: Tree, pattern: Tree): Option[Tuple] = {
-      def isTypeHoleDef(tree: Tree): Boolean =
-        tree match
-          case tree: TypeDef =>
-            tree.symbol.hasAnnotation(dotc.core.Symbols.defn.InternalQuotedPatterns_patternTypeAnnot)
-          case _ => false
-
-      def extractTypeHoles(pat: Term): (Term, List[Symbol]) =
-        pat match
-          case tpd.Inlined(_, Nil, pat2) => extractTypeHoles(pat2)
-          case tpd.Block(stats @ ((typeHole: TypeDef) :: _), expr) if isTypeHoleDef(typeHole) =>
-            val holes = stats.takeWhile(isTypeHoleDef).map(_.symbol)
-            val otherStats = stats.dropWhile(isTypeHoleDef)
-            (tpd.cpy.Block(pat)(otherStats, expr), holes)
-          case _ =>
-            (pat, Nil)
+  def termMatch(scrutinee: reflect.Term, pattern: reflect.Term): Option[Tuple] =
+    treeMatch(scrutinee, pattern)
 
-      val (pat1, typeHoles) = extractTypeHoles(pattern)
+  def typeTreeMatch(scrutinee: reflect.TypeTree, pattern: reflect.TypeTree): Option[Tuple] =
+    treeMatch(scrutinee, pattern)
 
-      val ctx1 =
-        if typeHoles.isEmpty then ctx
-        else
-          val ctx1 = ctx.fresh.setFreshGADTBounds.addMode(dotc.core.Mode.GadtConstraintInference)
-          ctx1.gadt.addToConstraint(typeHoles)
-          ctx1
-
-      val qctx1 = dotty.tools.dotc.quoted.QuoteContextImpl()(using ctx1)
-        .asInstanceOf[QuoteContext { val reflect: QuoteContextImpl.this.reflect.type }]
+  private def treeMatch(scrutinee: reflect.Tree, pattern: reflect.Tree): Option[Tuple] = {
+    import reflect._
+    given Context = rootContext
+    def isTypeHoleDef(tree: Tree): Boolean =
+      tree match
+        case tree: TypeDef =>
+          tree.symbol.hasAnnotation(dotc.core.Symbols.defn.InternalQuotedPatterns_patternTypeAnnot)
+        case _ => false
 
-      val matcher = new Matcher.QuoteMatcher[qctx1.type](qctx1) {
-        def patternHoleSymbol: Symbol = dotc.core.Symbols.defn.InternalQuotedPatterns_patternHole
-        def higherOrderHoleSymbol: Symbol = dotc.core.Symbols.defn.InternalQuotedPatterns_higherOrderHole
-      }
+    def extractTypeHoles(pat: Term): (Term, List[Symbol]) =
+      pat match
+        case tpd.Inlined(_, Nil, pat2) => extractTypeHoles(pat2)
+        case tpd.Block(stats @ ((typeHole: TypeDef) :: _), expr) if isTypeHoleDef(typeHole) =>
+          val holes = stats.takeWhile(isTypeHoleDef).map(_.symbol)
+          val otherStats = stats.dropWhile(isTypeHoleDef)
+          (tpd.cpy.Block(pat)(otherStats, expr), holes)
+        case _ =>
+          (pat, Nil)
+
+    val (pat1, typeHoles) = extractTypeHoles(pattern)
+
+    val ctx1 =
+      if typeHoles.isEmpty then ctx
+      else
+        val ctx1 = ctx.fresh.setFreshGADTBounds.addMode(dotc.core.Mode.GadtConstraintInference)
+        ctx1.gadt.addToConstraint(typeHoles)
+        ctx1
+
+    val qctx1 = dotty.tools.dotc.quoted.QuoteContextImpl()(using ctx1)
+      .asInstanceOf[QuoteContext & scala.internal.quoted.CompilerInterface]
+
+    val matcher = new Matcher.QuoteMatcher[qctx1.type](qctx1) {
+      def patternHoleSymbol: qctx1.reflect.Symbol = dotc.core.Symbols.defn.InternalQuotedPatterns_patternHole.asInstanceOf
+      def higherOrderHoleSymbol: qctx1.reflect.Symbol = dotc.core.Symbols.defn.InternalQuotedPatterns_higherOrderHole.asInstanceOf
+    }
 
-      val matchings =
-        if pat1.isType then matcher.termMatch(scrutinee, pat1)
-        else matcher.termMatch(scrutinee, pat1)
-
-      // val matchings = matcher.termMatch(scrutinee, pattern)
-      if typeHoles.isEmpty then matchings
-      else {
-        // After matching and doing all subtype checks, we have to approximate all the type bindings
-        // that we have found, seal them in a quoted.Type and add them to the result
-        def typeHoleApproximation(sym: Symbol) =
-          ctx1.gadt.approximation(sym, !sym.hasAnnotation(dotc.core.Symbols.defn.InternalQuotedPatterns_fromAboveAnnot)).seal
-        matchings.map { tup =>
-          Tuple.fromIArray(typeHoles.map(typeHoleApproximation).toArray.asInstanceOf[IArray[Object]]) ++ tup
-        }
+    val matchings =
+      if pat1.isType then matcher.termMatch(scrutinee.asInstanceOf[matcher.qctx.reflect.Term], pat1.asInstanceOf[matcher.qctx.reflect.Term])
+      else matcher.termMatch(scrutinee.asInstanceOf[matcher.qctx.reflect.Term], pat1.asInstanceOf[matcher.qctx.reflect.Term])
+
+    // val matchings = matcher.termMatch(scrutinee, pattern)
+    if typeHoles.isEmpty then matchings
+    else {
+      // After matching and doing all subtype checks, we have to approximate all the type bindings
+      // that we have found, seal them in a quoted.Type and add them to the result
+      def typeHoleApproximation(sym: Symbol) =
+        ctx1.gadt.approximation(sym, !sym.hasAnnotation(dotc.core.Symbols.defn.InternalQuotedPatterns_fromAboveAnnot)).asInstanceOf[qctx1.reflect.TypeRepr].seal
+      matchings.map { tup =>
+        Tuple.fromIArray(typeHoles.map(typeHoleApproximation).toArray.asInstanceOf[IArray[Object]]) ++ tup
       }
     }
-
-  end reflect
+  }
 
   private[this] val hash = QuoteContextImpl.scopeId(using ctx)
   override def hashCode: Int = hash

library/src-bootstrapped/scala/internal/quoted/Expr.scala

@@ -1,7 +1,7 @@
 package scala.internal.quoted
 
 import scala.quoted._
-import scala.internal.tasty.CompilerInterface.quoteContextWithCompilerInterface
+import scala.internal.quoted.CompilerInterface.quoteContextWithCompilerInterface
 
 /** An Expr backed by a tree. Only the current compiler trees are allowed.
  *
@@ -54,7 +54,7 @@ object Expr {
   def unapply[TypeBindings <: Tuple, Tup <: Tuple](scrutineeExpr: scala.quoted.Expr[Any])
         (using patternExpr: scala.quoted.Expr[Any], qctx: QuoteContext): Option[Tup] = {
     val qctx1 = quoteContextWithCompilerInterface(qctx)
-    qctx1.reflect.termMatch(scrutineeExpr.unseal, patternExpr.unseal).asInstanceOf[Option[Tup]]
+    qctx1.termMatch(scrutineeExpr.unseal, patternExpr.unseal).asInstanceOf[Option[Tup]]
   }
 
   /** Returns a null expresssion equivalent to `'{null}` */

library/src-bootstrapped/scala/internal/quoted/Type.scala

@@ -1,7 +1,7 @@
 package scala.internal.quoted
 
 import scala.quoted._
-import scala.internal.tasty.CompilerInterface.quoteContextWithCompilerInterface
+import scala.internal.quoted.CompilerInterface.quoteContextWithCompilerInterface
 
 /** Quoted type (or kind) `T` backed by a tree */
 final class Type[Tree](val typeTree: Tree, val scopeId: Int) extends scala.quoted.Type[Any] {
@@ -37,7 +37,7 @@ object Type {
   def unapply[TypeBindings <: Tuple, Tup <: Tuple](scrutineeType: scala.quoted.Type[_])
       (using patternType: scala.quoted.Type[_], qctx: QuoteContext): Option[Tup] = {
     val qctx1 = quoteContextWithCompilerInterface(qctx)
-    qctx1.reflect.typeTreeMatch(scrutineeType.unseal, patternType.unseal).asInstanceOf[Option[Tup]]
+    qctx1.typeTreeMatch(scrutineeType.unseal, patternType.unseal).asInstanceOf[Option[Tup]]
   }
 
 

library/src-bootstrapped/scala/quoted/Expr.scala

@@ -1,7 +1,5 @@
 package scala.quoted
 
-import scala.internal.tasty.CompilerInterface.quoteContextWithCompilerInterface
-
 /** Quoted expression of type `T` */
 abstract class Expr[+T] private[scala] {
 

library/src-non-bootstrapped/scala/internal/quoted/Expr.scala

@@ -1,7 +1,6 @@
 package scala.internal.quoted
 
 import scala.quoted._
-import scala.internal.tasty.CompilerInterface.quoteContextWithCompilerInterface
 
 /** An Expr backed by a tree. Only the current compiler trees are allowed.
  *

library/src-non-bootstrapped/scala/internal/quoted/Type.scala

@@ -1,7 +1,6 @@
 package scala.internal.quoted
 
 import scala.quoted._
-import scala.internal.tasty.CompilerInterface.quoteContextWithCompilerInterface
 
 /** Quoted type (or kind) `T` backed by a tree */
 final class Type[Tree](val typeTree: Tree, val scopeId: Int) extends scala.quoted.Type[Any] {

library/src/scala/internal/tasty/CompilerInterface.scala renamed to library/src/scala/internal/quoted/CompilerInterface.scala

@@ -1,15 +1,13 @@
-package scala.internal.tasty
+package scala.internal.quoted
 
 import scala.quoted.QuoteContext
 import scala.tasty.reflect._
 import scala.internal.quoted.PickledQuote
 
 /** Part of the reflection interface that needs to be implemented by the compiler */
-trait CompilerInterface { self: scala.tasty.Reflection =>
+trait CompilerInterface { self: scala.quoted.QuoteContext =>
 
-  //////////////////////
-  // QUOTE UNPICKLING //
-  //////////////////////
+  import self.reflect._
 
   /** Unpickle `repr` which represents a pickled `Expr` tree,
    *  replacing splice nodes with `holes`
@@ -56,7 +54,7 @@ trait CompilerInterface { self: scala.tasty.Reflection =>
 
 object CompilerInterface {
 
-  private[scala] def quoteContextWithCompilerInterface(qctx: QuoteContext): qctx.type { val reflect: qctx.reflect.type & scala.internal.tasty.CompilerInterface } =
-    qctx.asInstanceOf[qctx.type { val reflect: qctx.reflect.type & scala.internal.tasty.CompilerInterface }]
+  private[scala] def quoteContextWithCompilerInterface(qctx: QuoteContext): qctx.type { val reflect: qctx.reflect.type } & CompilerInterface =
+    qctx.asInstanceOf[qctx.type { val reflect: qctx.reflect.type } & CompilerInterface]
 
 }

library/src/scala/internal/quoted/PickledQuote.scala

@@ -1,7 +1,6 @@
 package scala.internal.quoted
 
 import scala.quoted._
-import scala.internal.tasty.CompilerInterface.quoteContextWithCompilerInterface
 
 /** Pickled representation of a quoted expression or type */
 trait PickledQuote:
@@ -18,13 +17,13 @@ trait PickledQuote:
 object PickledQuote:
 
   def unpickleExpr[T](pickledQuote: PickledQuote): QuoteContext ?=> Expr[T] =
-    val qctx = quoteContextWithCompilerInterface(summon[QuoteContext])
-    val tree = qctx.reflect.unpickleTerm(pickledQuote)
+    val qctx = CompilerInterface.quoteContextWithCompilerInterface(summon[QuoteContext])
+    val tree = qctx.unpickleTerm(pickledQuote)
     new scala.internal.quoted.Expr(tree, qctx.hashCode).asInstanceOf[Expr[T]]
 
   def unpickleType[T](pickledQuote: PickledQuote): QuoteContext ?=> Type[T] =
-    val qctx = quoteContextWithCompilerInterface(summon[QuoteContext])
-    val tree = qctx.reflect.unpickleTypeTree(pickledQuote)
+    val qctx = CompilerInterface.quoteContextWithCompilerInterface(summon[QuoteContext])
+    val tree = qctx.unpickleTypeTree(pickledQuote)
     new scala.internal.quoted.Type(tree, qctx.hashCode).asInstanceOf[Type[T]]
 
   /** Create an instance of PickledExpr from encoded tasty and sequence of labmdas to fill holes

library/src/scala/tasty/Reflection.scala

@@ -1,7 +1,5 @@
 package scala.tasty
 
-import scala.internal.tasty.CompilerInterface
-
 import scala.quoted.QuoteContext
 import scala.tasty.reflect._
 

tests/run-macros/quote-matcher-runtime/quoted_1.scala

@@ -13,8 +13,6 @@ object Macros {
           s"Expr(${r.unseal.show})"
         case r: Type[_] =>
           s"Type(${r.unseal.show})"
-        case r: String =>
-          s"String($r)"
       }
     }