Skip to content

Commit 5fa69ad

Browse files
authored
[CI] Disable publishing failing scans (#21528)
[This sbt command](https://github.com/scala/scala3/blob/e9e046db1d8a0329f28f52c7726dab66730dac7a/project/scripts/cmdTests#L58) is expected to fail. Consequently [its Develocity scan](https://develocity.scala-lang.org/s/cjyfzepco743i) always appear as failed, even though the CI job succeeds. This is confusing and it makes it harder to find real failing jobs. The solution I propose in this PR is to disable publishing the scan of the command, using `-Dscan:false`. Ping @dotta
2 parents 78561ce + 46d7f95 commit 5fa69ad

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

project/scripts/cmdTests

+3-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ cp tests/neg-macros/i6371/A_1.scala $OUT/A.scala
5555
cp tests/neg-macros/i6371/B_2.scala $OUT/B.scala
5656
"$SBT" "scalac $OUT/A.scala -d $OUT1"
5757
rm $OUT/A.scala
58-
"$SBT" "scalac -classpath $OUT1 -d $OUT1 $OUT/B.scala" > "$tmp" 2>&1 || echo "ok"
58+
# this command is expected to fail
59+
# setting -Dscan=false disables publishing scans to develocity.scala-lang.org
60+
"$SBT" "scalac -classpath $OUT1 -d $OUT1 $OUT/B.scala -Dscan=false" > "$tmp" 2>&1 || echo "ok"
5961
# cat "$tmp" # for debugging
6062
grep -qe "B.scala:2:7" "$tmp"
6163
grep -qe "This location contains code that was inlined from A.scala:3" "$tmp"

0 commit comments

Comments
 (0)