Skip to content

Commit 3eece68

Browse files
Update base version to 3.4.1-RC1 (#19469)
Part of #19321 We are currently releasing nightlies with the wrong version. We should update this now. We do not need to wait until we can update the reference version. Now we can check MiMa against 3.4.0-RC1 to ensure that the API has not changed. However, that version has a couple of mistakes that will be fixed in 3.4.0-RC2.
2 parents 34628b3 + aae2d5d commit 3eece68

File tree

2 files changed

+22
-14
lines changed

2 files changed

+22
-14
lines changed

project/Build.scala

+4-3
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ object Build {
8585

8686
val referenceVersion = "3.3.1"
8787

88-
val baseVersion = "3.4.0-RC1"
88+
val baseVersion = "3.4.1-RC1"
8989

9090
// Versions used by the vscode extension to create a new project
9191
// This should be the latest published releases.
@@ -101,7 +101,7 @@ object Build {
101101
* set to 3.1.3. If it is going to be 3.1.0, it must be set to the latest
102102
* 3.0.x release.
103103
*/
104-
val previousDottyVersion = "3.3.1"
104+
val previousDottyVersion = "3.4.0-RC1"
105105

106106
object CompatMode {
107107
final val BinaryCompatible = 0
@@ -2163,7 +2163,8 @@ object Build {
21632163
(Compile/doc/target).value
21642164
},
21652165
commonMiMaSettings,
2166-
mimaBinaryIssueFilters ++= MiMaFilters.Library
2166+
mimaBackwardIssueFilters := MiMaFilters.LibraryBackwards,
2167+
mimaForwardIssueFilters := MiMaFilters.LibraryForward,
21672168
)
21682169
} else base
21692170
}

project/MiMaFilters.scala

+18-11
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,26 @@
22
import com.typesafe.tools.mima.core._
33

44
object MiMaFilters {
5-
val Library: Seq[ProblemFilter] = Seq(
6-
// New API in 3.4.X
7-
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule#FlagsModule.AbsOverride"),
8-
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule.ValOrDefDefTypeTest"),
9-
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule.ValOrDefDefMethods"),
10-
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule#defnModule.FunctionClass"),
11-
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule#defnModule.PolyFunctionClass"),
12-
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule#TypeReprMethods.dealiasKeepOpaques"),
13-
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule#SymbolMethods.paramVariance"),
14-
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule#TypeLambdaMethods.paramVariances"),
5+
val LibraryBackwards: Map[String, Seq[ProblemFilter]] = Map(
6+
// In general we should never have backwards incompatible changes in the library.
7+
// Only exceptional cases should be added here.
8+
Build.previousDottyVersion -> Seq(
9+
// This language feature was in 3.4.0-RC1 but will be removed in 3.4.0-RC2
10+
ProblemFilters.exclude[MissingFieldProblem]("scala.runtime.stdLibPatches.language#deprecated.ascriptionVarargsUnpacking"),
11+
ProblemFilters.exclude[MissingClassProblem]("scala.runtime.stdLibPatches.language$deprecated$ascriptionVarargsUnpacking$"),
12+
)
13+
)
14+
val LibraryForward: Map[String, Seq[ProblemFilter]] = Map(
15+
// Additions that require a new minor version of the library
16+
Build.previousDottyVersion -> Seq(
17+
// This language feature is not in 3.4.0-RC1 but will be added in 3.4.0-RC2
18+
ProblemFilters.exclude[MissingFieldProblem]("scala.runtime.stdLibPatches.language.3.5-migration"),
19+
ProblemFilters.exclude[MissingFieldProblem]("scala.runtime.stdLibPatches.language.3.5"),
20+
ProblemFilters.exclude[MissingClassProblem]("scala.runtime.stdLibPatches.language$3$u002E5$"),
21+
ProblemFilters.exclude[MissingClassProblem]("scala.runtime.stdLibPatches.language$3$u002E5$minusmigration$"),
22+
)
1523
)
1624
val TastyCore: Seq[ProblemFilter] = Seq(
17-
ProblemFilters.exclude[DirectMissingMethodProblem]("dotty.tools.tasty.TastyFormat.EXPLICITtpt"),
1825
)
1926
val Interfaces: Seq[ProblemFilter] = Seq(
2027
)

0 commit comments

Comments
 (0)