Fix IDE crash on @afterclass

nicolasstucki · nicolasstucki · commit 27032b595ca4 · 2017-08-28T12:51:00.000+02:00
The TreeAccumulater was stuck in an infinite loop over the
synthetic constructor of java annotations. This could be reproduced
by opening the CompilationTests.scala in the IDE.
diff --git a/compiler/src/dotty/tools/dotc/ast/Trees.scala b/compiler/src/dotty/tools/dotc/ast/Trees.scala
@@ -1231,7 +1231,10 @@ object Trees {
           case Ident(name) =>
             x
           case Select(qualifier, name) =>
-            this(x, qualifier)
+            val isJavaAnnotationConstructor =
+              name == nme.CONSTRUCTOR && tree.symbol.is(JavaDefined | Synthetic, butNot = Method)
+            if (isJavaAnnotationConstructor) x
+            else this(x, qualifier)
           case This(qual) =>
             x
           case Super(qual, mix) =>

Original file line number	Diff line number	Diff line change
`@@ -1231,7 +1231,10 @@ object Trees {`
`1231`	`1231`	`case Ident(name) =>`
`1232`	`1232`	`x`
`1233`	`1233`	`case Select(qualifier, name) =>`
`1234`		`- this(x, qualifier)`
	`1234`	`+ val isJavaAnnotationConstructor =`
	`1235`	`+ name == nme.CONSTRUCTOR && tree.symbol.is(JavaDefined \| Synthetic, butNot = Method)`
	`1236`	`+ if (isJavaAnnotationConstructor) x`
	`1237`	`+ else this(x, qualifier)`
`1235`	`1238`	`case This(qual) =>`
`1236`	`1239`	`x`
`1237`	`1240`	`case Super(qual, mix) =>`