Skip to content

Commit 6ff3891

Browse files
committed
Use a single repository in the bootstrap job
Recently, I changed the bootstap script to publish the "locker" build to scala-release-temp and only the bootstrapped "quick" build to scala-integration. This commit reverts back to the previous mechanism where "locker" is published to the same repo (scala-integration) and later overwritten. The reason is that we want to use scala-release-temp for publishing integration builds of commits that are not (yet) merged to scala/scala. Such builds are useful for preliminary testing / benchmarking of PRs / development revisions. This means that we want to add scala-release-temp as a resolver in the community build and the benchmark job. If we have same-named releases in both repos (one "locker", one "quick", so they are not the same), we would not know which one is being picked up. If we want to avoid the overwriting in the future, we could work on a solution that sets a different version number for "locker", but we have to be careful when building the modules; maybe setting the scalaBinaryVersion would be enough.
1 parent 0dab108 commit 6ff3891

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

scripts/jobs/integrate/bootstrap

+5-14
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Script Overview
44
# - determine scala version
55
# - determine module versions
6-
# - build minimal core (aka locker) of Scala, use the determined version number, publish to scala-release-temp
6+
# - build minimal core (aka locker) of Scala, use the determined version number, publish to scala-integration
77
# - build those modules where a binary compatible version doesn't exist, publish to scala-integration
88
# - build Scala using the previously built core and bootstrap modules, publish to scala-integration
99
# - for releases
@@ -98,15 +98,10 @@ mkdir -p $baseDir/ivy2
9898
rm -rf $baseDir/resolutionScratch_
9999
mkdir -p $baseDir/resolutionScratch_
100100

101-
# repo for the starr and locker builds
102-
releaseTempRepoUrl=${releaseTempRepoUrl-"https://scala-ci.typesafe.com/artifactory/scala-release-temp/"}
103-
# repo for the modules and the quick build
101+
# repo to publish builds
104102
integrationRepoUrl=${integrationRepoUrl-"https://scala-ci.typesafe.com/artifactory/scala-integration/"}
105103

106-
# the `releaseTempRepoUrl` needs to be in the repositories file to get starr when building quick and the modules.
107-
# `integrationRepoUrl` is there to find modules when building quick and other modules (e.g., partest requires xml).
108-
# the file is re-generated for running the stability test, this time with only `integrationRepoUrl`.
109-
generateRepositoriesConfig $releaseTempRepoUrl $integrationRepoUrl
104+
generateRepositoriesConfig $integrationRepoUrl
110105

111106
# ARGH trying to get this to work on multiple versions of sbt-extras...
112107
# the old version (on jenkins, and I don't want to upgrade for risk of breaking other builds) honors -sbt-dir
@@ -413,7 +408,7 @@ bootstrap() {
413408
git clone --reference $WORKSPACE/.git $WORKSPACE/.git $STARR_DIR
414409
cd $STARR_DIR
415410
git co $STARR_REF
416-
$SBT_CMD -no-colors $sbtArgs --warn "setupBootstrapStarr $releaseTempRepoUrl $STARR_VER" $clean publish >> $baseDir/logs/builds 2>&1
411+
$SBT_CMD -no-colors $sbtArgs --warn "setupBootstrapStarr $integrationRepoUrl $STARR_VER" $clean publish >> $baseDir/logs/builds 2>&1
417412
)
418413
fi
419414

@@ -427,7 +422,7 @@ bootstrap() {
427422
# publish more than just core: partest needs scalap
428423
# in sabbus lingo, the resulting Scala build will be used as starr to build the released Scala compiler
429424
if [ ! -z "$STARR_VER" ]; then SET_STARR=-Dstarr.version=$STARR_VER; fi
430-
$SBT_CMD -no-colors $sbtArgs $SET_STARR --warn "setupBootstrapLocker $releaseTempRepoUrl $SCALA_VER" $clean publish >> $baseDir/logs/builds 2>&1
425+
$SBT_CMD -no-colors $sbtArgs $SET_STARR --warn "setupBootstrapLocker $integrationRepoUrl $SCALA_VER" $clean publish >> $baseDir/logs/builds 2>&1
431426

432427
echo "### Building modules using locker"
433428

@@ -530,13 +525,9 @@ determineScalaVersion
530525
deriveModuleVersions
531526

532527
removeExistingBuilds $integrationRepoUrl
533-
removeExistingBuilds $releaseTempRepoUrl
534528

535529
bootstrap
536530

537-
# for stability testing and sonatype publishing, use artifacts in `integrationRepoUrl`
538-
generateRepositoriesConfig $integrationRepoUrl
539-
540531
if [ "$testStability" == "yes" ]
541532
then testStability
542533
fi

0 commit comments

Comments
 (0)